Changes to Lua gradient scraping

src/utils/SkLua.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkLua.h"
 
 #if SK_SUPPORT_GPU
@@ skipping 1249 matching lines @@
         }
     }
     return 0;
 }
 
 static int lshader_asAGradient(lua_State* L) {
     SkShader* shader = get_ref<SkShader>(L, 1);
     if (shader) {
         SkShader::GradientInfo info;
         sk_bzero(&info, sizeof(info));
+        shader->asAGradient(&info);
 
-        SkColor colors[3];  // hacked in for extracting info on 3 color case.
-        SkScalar pos[3];
-
-        info.fColorCount = 3;
-        info.fColors = &colors[0];
-        info.fColorOffsets = &pos[0];
+        SkAutoTArray<SkScalar> pos(info.fColorCount);

[reed1, 2016/06/28 17:50:18]

Can we move these two lines into the if, so we're not allocating if the type is
kNone?

+        info.fColorOffsets = pos.get();
 
         SkShader::GradientType t = shader->asAGradient(&info);
 
         if (SkShader::kNone_GradientType != t) {
             lua_newtable(L);
-            setfield_string(L, "type", gradtype2string(t));
-            setfield_number(L, "colorCount", info.fColorCount);
-            setfield_string(L, "tile", mode2string(info.fTileMode));
 
-            if (info.fColorCount == 3){
-                setfield_number(L, "midPos", pos[1]);
+            bool containsHardStops = false;
+            bool isEvenlySpaced    = true;
+            for (int i = 1; i < info.fColorCount; i++) {
+                if (SkScalarNearlyEqual(info.fColorOffsets[i], info.fColorOffsets[i-1])) {
+                    containsHardStops = true;
+                }
+                if (!SkScalarNearlyEqual(info.fColorOffsets[i], i/(info.fColorCount - 1.0f))) {
+                    isEvenlySpaced = false;
+                }
             }
 
+            setfield_string(L,  "type",               gradtype2string(t));
+            setfield_string(L,  "tile",               mode2string(info.fTileMode));
+            setfield_number(L,  "colorCount",         info.fColorCount);
+            setfield_boolean(L, "containsHardStops",  containsHardStops);
+            setfield_boolean(L, "isEvenlySpaced",     isEvenlySpaced);
+

[reed1, 2016/06/28 17:50:17]

We're not pushing the actual t-values into a table while we're here?

             return 1;
         }
     }
     return 0;
 }
 
 static int lshader_gc(lua_State* L) {
     get_ref<SkShader>(L, 1)->unref();
     return 0;
 }
@@ skipping 836 matching lines @@
     REG_CLASS(L, SkTextBlob);
     REG_CLASS(L, SkTypeface);
     REG_CLASS(L, SkXfermode);
 }
 
 extern "C" int luaopen_skia(lua_State* L);
 extern "C" int luaopen_skia(lua_State* L) {
     SkLua::Load(L);
     return 0;
 }