Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2103903002: [gin] Unify snapshot loading on Windows and other platforms. (Closed)

Created:
4 years, 5 months ago by oth
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[gin] Unify snapshot loading on Windows and other platforms. Removes extra v8 snapshot and natives validation on Windows. All platforms have the same validation henceforth. BUG=501799 Committed: https://crrev.com/10b5a96b363a6ff23176d27a2e7fb1bba300f089 Cr-Commit-Position: refs/heads/master@{#403430}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -260 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gin/BUILD.gn View 2 chunks +0 lines, -35 lines 0 comments Download
D gin/fingerprint/fingerprint_v8_snapshot.gypi View 1 chunk +0 lines, -47 lines 0 comments Download
D gin/fingerprint/fingerprint_v8_snapshot.py View 1 chunk +0 lines, -86 lines 0 comments Download
M gin/gin.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
M gin/v8_initializer.cc View 5 chunks +11 lines, -63 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
oth
jochen@chromium.org: Please review changes in gin. ben@chromium.org: Please review changes in BUILD.gn. Thank you Orion
4 years, 5 months ago (2016-06-28 15:03:48 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-06-29 15:16:10 UTC) #3
jochen (gone - plz use gerrit)
On 2016/06/29 at 15:16:10, jochen wrote: > lgtm (i also own build.gn btw)
4 years, 5 months ago (2016-06-29 15:16:36 UTC) #4
oth
On 2016/06/29 15:16:36, jochen wrote: > On 2016/06/29 at 15:16:10, jochen wrote: > > lgtm ...
4 years, 5 months ago (2016-06-30 08:21:54 UTC) #5
jochen (gone - plz use gerrit)
On 2016/06/30 at 08:21:54, oth wrote: > On 2016/06/29 15:16:36, jochen wrote: > > On ...
4 years, 5 months ago (2016-06-30 13:28:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103903002/20001
4 years, 5 months ago (2016-07-01 09:13:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 09:49:01 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/10b5a96b363a6ff23176d27a2e7fb1bba300f089 Cr-Commit-Position: refs/heads/master@{#403430}
4 years, 5 months ago (2016-07-01 09:50:26 UTC) #12
oth
4 years, 5 months ago (2016-07-12 13:12:17 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2141043002/ by oth@chromium.org.

The reason for reverting is: Investigate effect on Win7 startup.cold.blank_page
metrics.

BUG=501799,625516.

Powered by Google App Engine
This is Rietveld 408576698