Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 21039004: Revert 214172 "Revert 214162 "Make Platform::queryStorageUsageAn..." (Closed)

Created:
7 years, 4 months ago by kinuko
Modified:
7 years, 4 months ago
Reviewers:
kinuko
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 214172 "Revert 214162 "Make Platform::queryStorageUsageAn..." > Revert 214162 "Make Platform::queryStorageUsageAndQuota work fro..." > > > Make Platform::queryStorageUsageAndQuota work from worker threads > > > > For renderer/worker to browser side: > > - Always use thread-local QuotaDispatcher > > - Make QuotaDispatcher use ThreadSafeSender to send IPC msgs > > - Keep ipc_thread_id:request_id mapping in QuotaMessageFilter > > > > For browser to renderer/worker side: > > - Add QuotaMessageFilter to receive quota IPC msgs and > > to relay the msgs to the correct thread's QuotaDispatcher > > > > BUG=259660 > > TEST=no behavioral changes yet (fast/workers/*storagequota* after blink side changes) > > R=jam@chromium.org, michaeln@chromium.org > > > > Review URL: https://codereview.chromium.org/20015002 > > TBR=kinuko@chromium.org > > Review URL: https://codereview.chromium.org/21042002 TBR=kinuko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -29 lines) Patch
M trunk/src/content/child/child_thread.h View 3 chunks +7 lines, -0 lines 0 comments Download
M trunk/src/content/child/child_thread.cc View 4 chunks +13 lines, -7 lines 0 comments Download
M trunk/src/content/child/quota_dispatcher.h View 4 chunks +25 lines, -7 lines 0 comments Download
M trunk/src/content/child/quota_dispatcher.cc View 7 chunks +45 lines, -5 lines 0 comments Download
A + trunk/src/content/child/quota_message_filter.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/child/quota_message_filter.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/content_child.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/renderer_webkitplatformsupport_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M trunk/src/content/worker/worker_thread.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/content/worker/worker_webkitplatformsupport_impl.h View 3 chunks +4 lines, -1 line 0 comments Download
M trunk/src/content/worker/worker_webkitplatformsupport_impl.cc View 3 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kinuko
7 years, 4 months ago (2013-07-29 10:44:20 UTC) #1
kinuko
7 years, 4 months ago (2013-07-29 10:48:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r214173.

Powered by Google App Engine
This is Rietveld 408576698