Issue 21042002: Revert 214162 "Make Platform::queryStorageUsageAndQuota work fro..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21042002: Revert 214162 "Make Platform::queryStorageUsageAndQuota work fro..." (Closed)

Created:
7 years, 4 months ago by kinuko

Modified:
7 years, 4 months ago

Reviewers:
kinuko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 214162 "Make Platform::queryStorageUsageAndQuota work fro..." > Make Platform::queryStorageUsageAndQuota work from worker threads > > For renderer/worker to browser side: > - Always use thread-local QuotaDispatcher > - Make QuotaDispatcher use ThreadSafeSender to send IPC msgs > - Keep ipc_thread_id:request_id mapping in QuotaMessageFilter > > For browser to renderer/worker side: > - Add QuotaMessageFilter to receive quota IPC msgs and > to relay the msgs to the correct thread's QuotaDispatcher > > BUG=259660 > TEST=no behavioral changes yet (fast/workers/*storagequota* after blink side changes) > R=jam@chromium.org, michaeln@chromium.org > > Review URL: https://codereview.chromium.org/20015002 TBR=kinuko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214172

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -238 lines)			Patch
M	trunk/src/content/child/child_thread.h	View	3 chunks	+0 lines, -7 lines	0 comments	Download
MM	trunk/src/content/child/child_thread.cc	View	4 chunks	+7 lines, -13 lines	0 comments	Download
M	trunk/src/content/child/quota_dispatcher.h	View	4 chunks	+7 lines, -25 lines	0 comments	Download
M	trunk/src/content/child/quota_dispatcher.cc	View	7 chunks	+5 lines, -45 lines	0 comments	Download
D	trunk/src/content/child/quota_message_filter.h	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	trunk/src/content/child/quota_message_filter.cc	View	1 chunk	+0 lines, -63 lines	0 comments	Download
M	trunk/src/content/content_child.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/content/renderer/renderer_webkitplatformsupport_impl.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc	View	3 chunks	+4 lines, -10 lines	0 comments	Download
M	trunk/src/content/worker/worker_thread.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	trunk/src/content/worker/worker_webkitplatformsupport_impl.h	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	trunk/src/content/worker/worker_webkitplatformsupport_impl.cc	View	3 chunks	+6 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r214172.

Expand Messages | Collapse Messages