net/cookies/canonical_cookie_unittest.cc - Issue 2103863003: Make CanonicalCookie::Source() private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/canonical_cookie_unittest.cc

Issue 2103863003: Make CanonicalCookie::Source() private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@source

Patch Set: Merge Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cookies/canonical_cookie_unittest.cc

diff --git a/net/cookies/canonical_cookie_unittest.cc b/net/cookies/canonical_cookie_unittest.cc

index 21902c0076ed5e0cfbf2ea5a4455637f08217025..a52326391571b9cf47baf453bfdc5d562d13d7e0 100644

--- a/net/cookies/canonical_cookie_unittest.cc

+++ b/net/cookies/canonical_cookie_unittest.cc

@@ -21,7 +21,6 @@ TEST(CanonicalCookieTest, Constructor) {

CanonicalCookie cookie(url, "A", "2", "www.example.com", "/test",

current_time, base::Time(), current_time, false, false,

CookieSameSite::DEFAULT_MODE, COOKIE_PRIORITY_DEFAULT);

- EXPECT_EQ(url.GetOrigin(), cookie.Source());

EXPECT_EQ("A", cookie.Name());

EXPECT_EQ("2", cookie.Value());

EXPECT_EQ("www.example.com", cookie.Domain());

@@ -34,7 +33,6 @@ TEST(CanonicalCookieTest, Constructor) {

current_time, base::Time(), current_time, false,

false, CookieSameSite::DEFAULT_MODE,

COOKIE_PRIORITY_DEFAULT);

- EXPECT_EQ(url.GetOrigin(), cookie.Source());

EXPECT_EQ("A", cookie2.Name());

EXPECT_EQ("2", cookie2.Value());

EXPECT_EQ("", cookie2.Domain());

@@ -52,7 +50,6 @@ TEST(CanonicalCookieTest, Create) {

std::unique_ptr<CanonicalCookie> cookie(

CanonicalCookie::Create(url, "A=2", creation_time, options));

- EXPECT_EQ(url.GetOrigin(), cookie->Source());

EXPECT_EQ("A", cookie->Name());

EXPECT_EQ("2", cookie->Value());

EXPECT_EQ("www.example.com", cookie->Domain());

@@ -61,7 +58,6 @@ TEST(CanonicalCookieTest, Create) {

GURL url2("http://www.foo.com");

cookie = CanonicalCookie::Create(url2, "B=1", creation_time, options);

- EXPECT_EQ(url2.GetOrigin(), cookie->Source());

EXPECT_EQ("B", cookie->Name());

EXPECT_EQ("1", cookie->Value());

EXPECT_EQ("www.foo.com", cookie->Domain());

@@ -101,7 +97,6 @@ TEST(CanonicalCookieTest, Create) {

creation_time, base::Time(), false, false,

CookieSameSite::DEFAULT_MODE, false,

COOKIE_PRIORITY_DEFAULT);

- EXPECT_EQ(url.GetOrigin(), cookie->Source());

EXPECT_EQ("A", cookie->Name());

EXPECT_EQ("2", cookie->Value());

EXPECT_EQ(".www.example.com", cookie->Domain());

@@ -114,7 +109,6 @@ TEST(CanonicalCookieTest, Create) {

creation_time, base::Time(), false, false,

CookieSameSite::DEFAULT_MODE, false,

COOKIE_PRIORITY_DEFAULT);

- EXPECT_EQ(url.GetOrigin(), cookie->Source());

EXPECT_EQ("A", cookie->Name());

EXPECT_EQ("2", cookie->Value());

EXPECT_EQ(".www.example.com", cookie->Domain());

« no previous file with comments | « net/cookies/canonical_cookie.cc ('k') | net/cookies/cookie_monster.h » ('j') | no next file with comments »