net/cookies/canonical_cookie.cc - Issue 2103863003: Make CanonicalCookie::Source() private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/canonical_cookie.cc

Issue 2103863003: Make CanonicalCookie::Source() private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@source

Patch Set: Merge Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cookies/canonical_cookie.cc

diff --git a/net/cookies/canonical_cookie.cc b/net/cookies/canonical_cookie.cc

index 2469f28660aa073efe634e028a8c4c0a16d810eb..f8f0ca9d46b6c26066b43b6bdf7156a996ffab5d 100644

--- a/net/cookies/canonical_cookie.cc

+++ b/net/cookies/canonical_cookie.cc

@@ -219,7 +219,7 @@ std::unique_ptr<CanonicalCookie> CanonicalCookie::Create(

// Per 3.2.1 of "Deprecate modification of 'secure' cookies from non-secure

// origins", if the cookie's "secure-only-flag" is "true" and the requesting

// URL does not have a secure scheme, the cookie should be thrown away.

- // https://tools.ietf.org/html/draft-west-leave-secure-cookies-alone

+ // https://tools.ietf.org/html/draft-ietf-httpbis-cookie-alone

if (options.enforce_strict_secure() && parsed_cookie.IsSecure() &&

!url.SchemeIsCryptographic()) {

VLOG(kVlogSetCookies)

« no previous file with comments | « net/cookies/canonical_cookie.h ('k') | net/cookies/canonical_cookie_unittest.cc » ('j') | no next file with comments »