chrome/android/junit/src/org/chromium/chrome/browser/cookies/CanonicalCookieTest.java - Issue 2103863003: Make CanonicalCookie::Source() private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/cookies/CanonicalCookieTest.java

Issue 2103863003: Make CanonicalCookie::Source() private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@source

Patch Set: Merge Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/cookies/CookiesFetcher.java ('k') | chrome/browser/android/cookies/cookies_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/cookies/CanonicalCookieTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/cookies/CanonicalCookieTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/cookies/CanonicalCookieTest.java

index 9c1c31432c6a7fb07d992467d05dbeb5e6395649..9b24142193a258479b0e56c830a24efd660d6ebc 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/cookies/CanonicalCookieTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/cookies/CanonicalCookieTest.java

@@ -51,7 +51,6 @@ public class CanonicalCookieTest {

}

private static void assertCookiesEqual(CanonicalCookie lhs, CanonicalCookie rhs) {

- Assert.assertEquals(lhs.getUrl(), rhs.getUrl());

Assert.assertEquals(lhs.getName(), rhs.getName());

Assert.assertEquals(lhs.getValue(), rhs.getValue());

Assert.assertEquals(lhs.getDomain(), rhs.getDomain());

@@ -84,15 +83,15 @@ public class CanonicalCookieTest {

@Test

public void testSaveRestore() throws Exception {

ArrayList<CanonicalCookie> cookies = new ArrayList<>();

- cookies.add(new CanonicalCookie("http://url", "name", "value", "domain", "path",

- 0 /* creation */, 1 /* expiration */, 0 /* lastAccess */, false /* secure */,

- true /* httpOnly */, 0 /* sameSite */, 0 /* priority */));

- cookies.add(new CanonicalCookie("http://url2", "name2", "value2", "domain2", "path2",

- 10 /* creation */, 20 /* expiration */, 15 /* lastAccess */, true /* secure */,

- false /* httpOnly */, 1 /* sameSite */, 1 /* priority */));

- cookies.add(new CanonicalCookie("http://url3", "name3", "value3", "domain3", "path3",

- 10 /* creation */, 20 /* expiration */, 15 /* lastAccess */, true /* secure */,

- false /* httpOnly */, 2 /* sameSite */, 2 /* priority */));

+ cookies.add(new CanonicalCookie("name", "value", "domain", "path", 0 /* creation */,

+ 1 /* expiration */, 0 /* lastAccess */, false /* secure */, true /* httpOnly */,

+ 0 /* sameSite */, 0 /* priority */));

+ cookies.add(new CanonicalCookie("name2", "value2", ".domain2", "path2", 10 /* creation */,

+ 20 /* expiration */, 15 /* lastAccess */, true /* secure */, false /* httpOnly */,

+ 1 /* sameSite */, 1 /* priority */));

+ cookies.add(new CanonicalCookie("name3", "value3", "domain3", "path3", 10 /* creation */,

+ 20 /* expiration */, 15 /* lastAccess */, true /* secure */, false /* httpOnly */,

+ 2 /* sameSite */, 2 /* priority */));

doSaveRestoreCookiesListTest(cookies);

}