Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3023)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/cookies/CookiesFetcher.java

Issue 2103863003: Make CanonicalCookie::Source() private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@source
Patch Set: Merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/cookies/CookiesFetcher.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/cookies/CookiesFetcher.java b/chrome/android/java/src/org/chromium/chrome/browser/cookies/CookiesFetcher.java
index 0cfafdb92009a3fcf0e64e60c553e08c8173583e..a7843d8c8d5279960dac5681ae09b10d32f1bed9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/cookies/CookiesFetcher.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/cookies/CookiesFetcher.java
@@ -150,11 +150,10 @@ public class CookiesFetcher {
protected void onPostExecute(List<CanonicalCookie> cookies) {
// We can only access cookies and profiles on the UI thread.
for (CanonicalCookie cookie : cookies) {
- nativeRestoreCookies(cookie.getUrl(), cookie.getName(), cookie.getValue(),
- cookie.getDomain(), cookie.getPath(), cookie.getCreationDate(),
- cookie.getExpirationDate(), cookie.getLastAccessDate(),
- cookie.isSecure(), cookie.isHttpOnly(), cookie.getSameSite(),
- cookie.getPriority());
+ nativeRestoreCookies(cookie.getName(), cookie.getValue(), cookie.getDomain(),
+ cookie.getPath(), cookie.getCreationDate(), cookie.getExpirationDate(),
+ cookie.getLastAccessDate(), cookie.isSecure(), cookie.isHttpOnly(),
+ cookie.getSameSite(), cookie.getPriority());
}
}
}.executeOnExecutor(AsyncTask.SERIAL_EXECUTOR);
@@ -196,10 +195,10 @@ public class CookiesFetcher {
}
@CalledByNative
- private CanonicalCookie createCookie(String url, String name, String value, String domain,
- String path, long creation, long expiration, long lastAccess, boolean secure,
- boolean httpOnly, int sameSite, int priority) {
- return new CanonicalCookie(url, name, value, domain, path, creation, expiration, lastAccess,
+ private CanonicalCookie createCookie(String name, String value, String domain, String path,
+ long creation, long expiration, long lastAccess, boolean secure, boolean httpOnly,
+ int sameSite, int priority) {
+ return new CanonicalCookie(name, value, domain, path, creation, expiration, lastAccess,
secure, httpOnly, sameSite, priority);
}
@@ -269,7 +268,7 @@ public class CookiesFetcher {
private native long nativeInit();
private static native void nativeDestroy(long nativeCookiesFetcher);
private native void nativePersistCookies(long nativeCookiesFetcher);
- private static native void nativeRestoreCookies(String url, String name, String value,
- String domain, String path, long creation, long expiration, long lastAccess,
- boolean secure, boolean httpOnly, int sameSite, int priority);
+ private static native void nativeRestoreCookies(String name, String value, String domain,
+ String path, long creation, long expiration, long lastAccess, boolean secure,
+ boolean httpOnly, int sameSite, int priority);
}

Powered by Google App Engine
This is Rietveld 408576698