Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2103783002: Convert video-seeking*, video-set* and video-single* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-seeking*, video-set* and video-single* tests to testharness.js Cleaning up video-seeking*, video-set* and video-single* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/7175614caf3be7fa22ce4a8f61aff2dac9972863 Cr-Commit-Position: refs/heads/master@{#402441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -152 lines) Patch
M third_party/WebKit/LayoutTests/media/video-seeking.html View 1 chunk +19 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-seeking-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-set-rate-from-pause.html View 1 chunk +17 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-set-rate-from-pause-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-single-valid-source.html View 1 chunk +24 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-single-valid-source-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Srirama
PTAL
4 years, 5 months ago (2016-06-28 07:00:53 UTC) #3
fs
lgtm
4 years, 5 months ago (2016-06-28 09:09:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103783002/1
4 years, 5 months ago (2016-06-28 09:32:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 10:43:56 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 10:45:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7175614caf3be7fa22ce4a8f61aff2dac9972863
Cr-Commit-Position: refs/heads/master@{#402441}

Powered by Google App Engine
This is Rietveld 408576698