Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments, add more tests. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebFrameClient.h
diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h
index d8d94066207f125798398a30754cc574b75d11f5..2e5f3022a7af8c225209d30546ad61b39c35ff63 100644
--- a/third_party/WebKit/public/web/WebFrameClient.h
+++ b/third_party/WebKit/public/web/WebFrameClient.h
@@ -344,6 +344,12 @@ public:
// The 'load' event was dispatched.
virtual void didHandleOnloadEvents(WebLocalFrame*) { }
+ // The 'beforeunload' event was dispatched, a dialog probably was shown, and
+ // the navigation is not aborted. |eventListenerCalled| is true if at least
+ // one frame (in the tree that is being closed) had a beforeunload event
+ // handler invoked.
+ virtual void didHandleOnBeforeUnloadEvent(bool eventListenerCalled) {}
+
// The frame's document or one of its subresources failed to load. The
// WebHistoryCommitType is the commit type that would have been used had the
// load succeeded.

Powered by Google App Engine
This is Rietveld 408576698