Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments, add more tests. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 // This method may not execute JavaScript code. 337 // This method may not execute JavaScript code.
338 virtual void didFinishDocumentLoad(WebLocalFrame*) { } 338 virtual void didFinishDocumentLoad(WebLocalFrame*) { }
339 339
340 // Like |didFinishDocumentLoad|, except this method may run JavaScript 340 // Like |didFinishDocumentLoad|, except this method may run JavaScript
341 // code (and possibly invalidate the frame). 341 // code (and possibly invalidate the frame).
342 virtual void runScriptsAtDocumentReady(WebLocalFrame*, bool documentIsEmpty) { } 342 virtual void runScriptsAtDocumentReady(WebLocalFrame*, bool documentIsEmpty) { }
343 343
344 // The 'load' event was dispatched. 344 // The 'load' event was dispatched.
345 virtual void didHandleOnloadEvents(WebLocalFrame*) { } 345 virtual void didHandleOnloadEvents(WebLocalFrame*) { }
346 346
347 // The 'beforeunload' event was dispatched, a dialog probably was shown, and
348 // the navigation is not aborted. |eventListenerCalled| is true if at least
349 // one frame (in the tree that is being closed) had a beforeunload event
350 // handler invoked.
351 virtual void didHandleOnBeforeUnloadEvent(bool eventListenerCalled) {}
352
347 // The frame's document or one of its subresources failed to load. The 353 // The frame's document or one of its subresources failed to load. The
348 // WebHistoryCommitType is the commit type that would have been used had the 354 // WebHistoryCommitType is the commit type that would have been used had the
349 // load succeeded. 355 // load succeeded.
350 virtual void didFailLoad(WebLocalFrame*, const WebURLError&, WebHistoryCommi tType) { } 356 virtual void didFailLoad(WebLocalFrame*, const WebURLError&, WebHistoryCommi tType) { }
351 357
352 // The frame's document and all of its subresources succeeded to load. 358 // The frame's document and all of its subresources succeeded to load.
353 virtual void didFinishLoad(WebLocalFrame*) { } 359 virtual void didFinishLoad(WebLocalFrame*) { }
354 360
355 // The navigation resulted in no change to the documents within the page. 361 // The navigation resulted in no change to the documents within the page.
356 // For example, the navigation may have just resulted in scrolling to a 362 // For example, the navigation may have just resulted in scrolling to a
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
718 // Mojo ---------------------------------------------------------------- 724 // Mojo ----------------------------------------------------------------
719 virtual ServiceRegistry* serviceRegistry() { return nullptr; } 725 virtual ServiceRegistry* serviceRegistry() { return nullptr; }
720 726
721 protected: 727 protected:
722 virtual ~WebFrameClient() { } 728 virtual ~WebFrameClient() { }
723 }; 729 };
724 730
725 } // namespace blink 731 } // namespace blink
726 732
727 #endif 733 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698