Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: components/safe_browsing_db/v4_update_protocol_manager.h

Issue 2103693002: SafeBrowsing PVer4: Send mutable response to the database and the stores (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_ReadFromDisk
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_update_protocol_manager.h
diff --git a/components/safe_browsing_db/v4_update_protocol_manager.h b/components/safe_browsing_db/v4_update_protocol_manager.h
index 1439cc65900af85b1a5eaf2067449405afff3ecd..053229824a50833289cc330896fec6c48358b52c 100644
--- a/components/safe_browsing_db/v4_update_protocol_manager.h
+++ b/components/safe_browsing_db/v4_update_protocol_manager.h
@@ -41,7 +41,8 @@ class V4UpdateProtocolManagerFactory;
// Parameters:
// - The vector of update response protobufs received from the server for
// each list type.
-typedef base::Callback<void(const std::vector<ListUpdateResponse>&)>
+typedef base::Callback<void(
+ std::unique_ptr<ParsedServerResponse> parsed_server_response)>
Scott Hess - ex-Googler 2016/06/28 03:58:43 Don't need the parameter's name in this context, j
vakh (use Gerrit instead) 2016/06/28 21:34:14 Done.
V4UpdateCallback;
class V4UpdateProtocolManager : public net::URLFetcherDelegate,
@@ -104,9 +105,8 @@ class V4UpdateProtocolManager : public net::URLFetcherDelegate,
// FetchThreatListUpdatesResponse protobuf and returns each of the
// ListUpdateResponse protobufs contained in it as a vector.
// Returns true if parsing is successful, false otherwise.
- bool ParseUpdateResponse(
- const std::string& data_base64,
- std::vector<ListUpdateResponse>* list_update_responses);
+ bool ParseUpdateResponse(const std::string& data_base64,
+ ParsedServerResponse* parsed_server_response);
// Resets the update error counter and multiplier.
void ResetUpdateErrors();

Powered by Google App Engine
This is Rietveld 408576698