SafeBrowsing PVer4: Send mutable response to the database and the stores

components/safe_browsing_db/v4_update_protocol_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SAFE_BROWSING_DB_V4_UPDATE_PROTOCOL_MANAGER_H_
 #define COMPONENTS_SAFE_BROWSING_DB_V4_UPDATE_PROTOCOL_MANAGER_H_
 
 // A class that implements Chrome's interface with the SafeBrowsing V4 update
 // protocol.
 //
@@ skipping 23 matching lines @@
 }  // namespace net
 
 namespace safe_browsing {
 
 class V4UpdateProtocolManagerFactory;
 
 // V4UpdateCallback is invoked when a scheduled update completes.
 // Parameters:
 //   - The vector of update response protobufs received from the server for
 //     each list type.
-typedef base::Callback<void(const std::vector<ListUpdateResponse>&)>
+typedef base::Callback<void(
+    std::unique_ptr<ParsedServerResponse> parsed_server_response)>

[Scott Hess - ex-Googler, 2016/06/28 03:58:43]

Don't need the parameter's name in this context, just the type.

[vakh (use Gerrit instead), 2016/06/28 21:34:14]

Done.

     V4UpdateCallback;
 
 class V4UpdateProtocolManager : public net::URLFetcherDelegate,
                                 public base::NonThreadSafe {
  public:
   ~V4UpdateProtocolManager() override;
 
   // Makes the passed |factory| the factory used to instantiate
   // a V4UpdateProtocolManager. Useful for tests.
   static void RegisterFactory(V4UpdateProtocolManagerFactory* factory) {
@@ skipping 42 matching lines @@
 
   // Fills a FetchThreatListUpdatesRequest protocol buffer for a request.
   // Returns the serialized and base 64 encoded request as a string.
   static std::string GetBase64SerializedUpdateRequestProto(
       const StoreStateMap& store_state_map);
 
   // Parses the base64 encoded response received from the server as a
   // FetchThreatListUpdatesResponse protobuf and returns each of the
   // ListUpdateResponse protobufs contained in it as a vector.
   // Returns true if parsing is successful, false otherwise.
-  bool ParseUpdateResponse(
-      const std::string& data_base64,
-      std::vector<ListUpdateResponse>* list_update_responses);
+  bool ParseUpdateResponse(const std::string& data_base64,
+                           ParsedServerResponse* parsed_server_response);
 
   // Resets the update error counter and multiplier.
   void ResetUpdateErrors();
 
   // Updates internal update and backoff state for each update response error,
   // assuming that the current time is |now|.
   void HandleUpdateError(const base::Time& now);
 
   // Generates the URL for the update request and issues the request for the
   // lists passed to the constructor.
@@ skipping 65 matching lines @@
       const V4ProtocolConfig& config,
       V4UpdateCallback callback) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(V4UpdateProtocolManagerFactory);
 };
 
 }  // namespace safe_browsing
 
 #endif  // COMPONENTS_SAFE_BROWSING_DB_V4_UPDATE_PROTOCOL_MANAGER_H_