components/safe_browsing_db/v4_local_database_manager.h - Issue 2103693002: SafeBrowsing PVer4: Send mutable response to the database and the stores

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_local_database_manager.h

Issue 2103693002: SafeBrowsing PVer4: Send mutable response to the database and the stores (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_ReadFromDisk

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing_db/v4_database_unittest.cc ('K') | « components/safe_browsing_db/v4_database_unittest.cc ('k') | components/safe_browsing_db/v4_local_database_manager.cc » ('j') | components/safe_browsing_db/v4_protocol_manager_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_local_database_manager.h

diff --git a/components/safe_browsing_db/v4_local_database_manager.h b/components/safe_browsing_db/v4_local_database_manager.h

index ae1ee65148a337a306aef21edf453cb075860326..0bc033f0381e6152e830181729f56f87ac8cbbf8 100644

--- a/components/safe_browsing_db/v4_local_database_manager.h

+++ b/components/safe_browsing_db/v4_local_database_manager.h

@@ -62,7 +62,8 @@ class V4LocalDatabaseManager : public SafeBrowsingDatabaseManager {

// The callback called each time the protocol manager downloads updates

// successfully.

- void UpdateRequestCompleted(const std::vector<ListUpdateResponse>& responses);

+ void UpdateRequestCompleted(

+ std::unique_ptr<ParsedServerResponse> parsed_server_response);

Scott Hess - ex-Googler 2016/06/28 03:58:43 I'd say "responses" is still a reasonable argument

void SetupUpdateProtocolManager(

net::URLRequestContextGetter* request_context_getter,