components/safe_browsing_db/v4_local_database_manager.cc - Issue 2103693002: SafeBrowsing PVer4: Send mutable response to the database and the stores

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_local_database_manager.cc

Issue 2103693002: SafeBrowsing PVer4: Send mutable response to the database and the stores (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_ReadFromDisk

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing_db/v4_local_database_manager.h ('K') | « components/safe_browsing_db/v4_local_database_manager.h ('k') | components/safe_browsing_db/v4_protocol_manager_util.h » ('j') | components/safe_browsing_db/v4_protocol_manager_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_local_database_manager.cc

diff --git a/components/safe_browsing_db/v4_local_database_manager.cc b/components/safe_browsing_db/v4_local_database_manager.cc

index f1f484ce8e74b30ddc3ca2afe4d529756fe7ef05..b1692bc5ff025f699d99fca0efd3b99fe14ef5c7 100644

--- a/components/safe_browsing_db/v4_local_database_manager.cc

+++ b/components/safe_browsing_db/v4_local_database_manager.cc

@@ -251,9 +251,10 @@ void V4LocalDatabaseManager::StopOnIOThread(bool shutdown) {

}

void V4LocalDatabaseManager::UpdateRequestCompleted(

- const std::vector<ListUpdateResponse>& responses) {

+ std::unique_ptr<ParsedServerResponse> parsed_server_response) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

- v4_database_->ApplyUpdate(responses, db_updated_callback_);

+ v4_database_->ApplyUpdate(std::move(parsed_server_response),

+ db_updated_callback_);

}

void V4LocalDatabaseManager::DatabaseUpdated() {