Add GN rules for building instrumented libraries.

Add GN rules for building instrumented libraries.

BUG=585127
Committed: https://crrev.com/fba9bdbfc9ccc9c7909e1bd4784bcb05df9da649
Cr-Commit-Position: refs/heads/master@{#406452}

[Sam McNally, 2016-06-29 01:35:16]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-06-29 01:38:13]

sammc@chromium.org changed reviewers:
+ eugenis@chromium.org

[eugenis, 2016-06-29 20:10:24]

Description was changed from

==========
Add GN rules for building instrumented libraries.

BUG=585127
==========

to

==========
Add GN rules for building instrumented libraries.

BUG=585127
==========

[eugenis, 2016-06-29 20:10:24]

eugenis@chromium.org changed reviewers:
+ aizatsky@chromium.org

[aizatsky, 2016-06-29 21:14:32]

https://codereview.chromium.org/2103683002/diff/20001/third_party/instrumente...
File third_party/instrumented_libraries/scripts/build_and_package.py (right):

https://codereview.chromium.org/2103683002/diff/20001/third_party/instrumente...
third_party/instrumented_libraries/scripts/build_and_package.py:44: 'is_msan =
true',
What about asan builds?

I suggest you store additional gn arguments in build types map.

https://codereview.chromium.org/2103683002/diff/20001/third_party/instrumente...
third_party/instrumented_libraries/scripts/build_and_package.py:48:
'msan_track_origins = %d' % BUILD_TYPES[build_type],
This arg should go into BUILD_TYPES map.

https://codereview.chromium.org/2103683002/diff/20001/third_party/instrumente...
third_party/instrumented_libraries/scripts/build_and_package.py:53:
subprocess.check_call(['gn', 'gen', build_dir])
add --check

https://codereview.chromium.org/2103683002/diff/20001/third_party/instrumente...
third_party/instrumented_libraries/scripts/build_and_package.py:63: print 'To
upload, run:'
This will be printed out in between runs and will be hard to find. Let's put all
finishing prints out of this function and into main.

[Sam McNally, 2016-06-30 04:16:56]

Patchset #2 (id:40001) has been deleted

[Sam McNally, 2016-06-30 04:17:06]

https://codereview.chromium.org/2103683002/diff/20001/third_party/instrumente...
File third_party/instrumented_libraries/scripts/build_and_package.py (right):

https://codereview.chromium.org/2103683002/diff/20001/third_party/instrumente...
third_party/instrumented_libraries/scripts/build_and_package.py:44: 'is_msan =
true',
On 2016/06/29 21:14:32, aizatsky wrote:
> What about asan builds?
> 
> I suggest you store additional gn arguments in build types map.

Done.

https://codereview.chromium.org/2103683002/diff/20001/third_party/instrumente...
third_party/instrumented_libraries/scripts/build_and_package.py:48:
'msan_track_origins = %d' % BUILD_TYPES[build_type],
On 2016/06/29 21:14:32, aizatsky wrote:
> This arg should go into BUILD_TYPES map.

Done.

https://codereview.chromium.org/2103683002/diff/20001/third_party/instrumente...
third_party/instrumented_libraries/scripts/build_and_package.py:53:
subprocess.check_call(['gn', 'gen', build_dir])
On 2016/06/29 21:14:32, aizatsky wrote:
> add --check

Done.

https://codereview.chromium.org/2103683002/diff/20001/third_party/instrumente...
third_party/instrumented_libraries/scripts/build_and_package.py:63: print 'To
upload, run:'
On 2016/06/29 21:14:32, aizatsky wrote:
> This will be printed out in between runs and will be hard to find. Let's put
all
> finishing prints out of this function and into main.

Done.

[aizatsky, 2016-06-30 21:58:45]

lgtm

[eugenis, 2016-07-01 20:35:20]

Thanks you for working on this!
I assume you've run at least some of the chromium test suites with the newly
built libraries.
We should upload them to GCE for better testing, I can take care of that once
this CL lands. We have a mostly hermetic process for updating prebuilts in
supported configurations.

[Sam McNally, 2016-07-05 00:17:35]

On 2016/07/01 20:35:20, eugenis wrote:
> Thanks you for working on this!
> I assume you've run at least some of the chromium test suites with the newly
> built libraries.
> We should upload them to GCE for better testing, I can take care of that once
> this CL lands. We have a mostly hermetic process for updating prebuilts in
> supported configurations.

I ran the tests and as far as I can tell, the same tests fail as with
previously-built instrumented libraries on 14.04.

[Sam McNally, 2016-07-14 07:43:11]

ping

[eugenis, 2016-07-14 19:06:22]

On 2016/07/14 07:43:11, Sam McNally wrote:
> ping

lgtm

[Sam McNally, 2016-07-15 01:23:30]

sammc@chromium.org changed reviewers:
+ dpranke@chromium.org

[Sam McNally, 2016-07-15 01:23:31]

+dpranke for build/

[Dirk Pranke, 2016-07-15 02:58:32]

lgtm w/ formatting comments.

https://codereview.chromium.org/2103683002/diff/60001/third_party/instrumente...
File third_party/instrumented_libraries/BUILD.gn (right):

https://codereview.chromium.org/2103683002/diff/60001/third_party/instrumente...
third_party/instrumented_libraries/BUILD.gn:291:
instrumented_library("libcairo2") {
There should probably be blank lines in between these targets. Also, perhaps
they should be sorted?

[Sam McNally, 2016-07-20 00:19:48]

Patchset #3 (id:80001) has been deleted

[Sam McNally, 2016-07-20 00:20:29]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 00:21:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 01:45:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 01:45:09]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-07-20 01:46:58]

https://codereview.chromium.org/2103683002/diff/60001/third_party/instrumente...
File third_party/instrumented_libraries/BUILD.gn (right):

https://codereview.chromium.org/2103683002/diff/60001/third_party/instrumente...
third_party/instrumented_libraries/BUILD.gn:291:
instrumented_library("libcairo2") {
On 2016/07/15 02:58:32, Dirk Pranke wrote:
> There should probably be blank lines in between these targets. Also, perhaps
> they should be sorted?

Done.

[Sam McNally, 2016-07-20 01:47:15]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-07-20 01:47:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, eugenis@chromium.org, aizatsky@chromium.org
Link to the patchset: https://codereview.chromium.org/2103683002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-07-20 01:48:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 01:54:02]

Description was changed from

==========
Add GN rules for building instrumented libraries.

BUG=585127
==========

to

==========
Add GN rules for building instrumented libraries.

BUG=585127
==========

[commit-bot: I haz the power, 2016-07-20 01:54:04]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-07-20 01:54:23]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 01:55:30]

Description was changed from

==========
Add GN rules for building instrumented libraries.

BUG=585127
==========

to

==========
Add GN rules for building instrumented libraries.

BUG=585127

Committed: https://crrev.com/fba9bdbfc9ccc9c7909e1bd4784bcb05df9da649
Cr-Commit-Position: refs/heads/master@{#406452}
==========

[commit-bot: I haz the power, 2016-07-20 01:55:32]

Patchset 4 (id:??) landed as
https://crrev.com/fba9bdbfc9ccc9c7909e1bd4784bcb05df9da649
Cr-Commit-Position: refs/heads/master@{#406452}