tools/android/loading: Properly detect page loading failures

tools/android/loading/loading_trace.py

Index: tools/android/loading/loading_trace.py
diff --git a/tools/android/loading/loading_trace.py b/tools/android/loading/loading_trace.py
index beb6785c796fc18695649c71f99ffed622af0df1..1775d5a99a19c4d2d35a008d660e109ea409aa4c 100644
--- a/tools/android/loading/loading_trace.py
+++ b/tools/android/loading/loading_trace.py
@@ -68,6 +68,19 @@ class LoadingTrace(object):
     return LoadingTrace(json_dict[cls._URL_KEY], json_dict[cls._METADATA_KEY],
                         page, request, tracing_track)
 
+  def HasLoadingSucceed(self):

[mattcary, 2016/06/28 10:07:06]

Move this to the tracing track. Then you can test it easily, and it also avoids
leaking the tracing track into the loading trace.

[gabadie, 2016/06/28 11:42:45]

Makes sens. Done.

+    """Returns whether the loading has succeed at recording time."""
+    main_frame_id = self.tracing_track.GetMainFrameRoutingID()
+    for event in self.tracing_track.GetMatchingEvents(
+        'navigation', 'RenderFrameImpl::didFailProvisionalLoad'):
+      if event.args['id'] == main_frame_id:
+        return False
+    for event in self.tracing_track.GetMatchingEvents(
+        'navigation', 'RenderFrameImpl::didFailLoad'):
+      if event.args['id'] == main_frame_id:
+        return False
+    return True
+
   @classmethod
   def FromJsonFile(cls, json_path):
     """Returns an instance from a json file saved by ToJsonFile()."""