tools/android/loading: Properly detect page loading failures

tools/android/loading/loading_trace.py

 # Copyright (c) 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Represents the trace of a page load."""
 
 import datetime
 import json
 import time
 
@@ skipping 50 matching lines @@
             cls._TRACING_KEY)
     assert all(key in json_dict for key in keys)
     page = page_track.PageTrack.FromJsonDict(json_dict[cls._PAGE_KEY])
     request = request_track.RequestTrack.FromJsonDict(
         json_dict[cls._REQUEST_KEY])
     tracing_track = tracing.TracingTrack.FromJsonDict(
         json_dict[cls._TRACING_KEY])
     return LoadingTrace(json_dict[cls._URL_KEY], json_dict[cls._METADATA_KEY],
                         page, request, tracing_track)
 
+  def HasLoadingSucceed(self):

[mattcary, 2016/06/28 10:07:06]

Move this to the tracing track. Then you can test it easily, and it also avoids
leaking the tracing track into the loading trace.

[gabadie, 2016/06/28 11:42:45]

Makes sens. Done.

+    """Returns whether the loading has succeed at recording time."""
+    main_frame_id = self.tracing_track.GetMainFrameRoutingID()
+    for event in self.tracing_track.GetMatchingEvents(
+        'navigation', 'RenderFrameImpl::didFailProvisionalLoad'):
+      if event.args['id'] == main_frame_id:
+        return False
+    for event in self.tracing_track.GetMatchingEvents(
+        'navigation', 'RenderFrameImpl::didFailLoad'):
+      if event.args['id'] == main_frame_id:
+        return False
+    return True
+
   @classmethod
   def FromJsonFile(cls, json_path):
     """Returns an instance from a json file saved by ToJsonFile()."""
     with open(json_path) as input_file:
       return cls.FromJsonDict(json.load(input_file))
 
   @classmethod
   def RecordUrlNavigation(
       cls, url, connection, chrome_metadata, categories,
       timeout_seconds=devtools_monitor.DEFAULT_TIMEOUT_SECONDS,
@@ skipping 39 matching lines @@
     """
     self._tracing_json_str = json.dumps(self._tracing_track.ToJsonDict())
     self._tracing_track = None
 
   def _RestoreTracingTrack(self):
     if not self._tracing_json_str:
       return None
     self._tracing_track = tracing.TracingTrack.FromJsonDict(
         json.loads(self._tracing_json_str))
     self._tracing_json_str = None