Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 21036008: Add Loop Blinn hairline conics to GPU (Closed)

Created:
7 years, 4 months ago by egdaniel
Modified:
7 years, 4 months ago
Reviewers:
jvanverth1, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add Loop Blinn hairline conics to GPU BUG= R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=10487

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -91 lines) Patch
M samplecode/SampleHairCurves.cpp View 2 chunks +22 lines, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 13 chunks +145 lines, -91 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
egdaniel
Here is the Loop Blinn conic shader. For conics the bench shows that it is ...
7 years, 4 months ago (2013-07-31 18:26:02 UTC) #1
jvanverth1
Just some typos I noticed: https://codereview.chromium.org/21036008/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp File src/gpu/GrAAHairLinePathRenderer.cpp (right): https://codereview.chromium.org/21036008/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp#newcode168 src/gpu/GrAAHairLinePathRenderer.cpp:168: // Most cases will ...
7 years, 4 months ago (2013-07-31 18:41:39 UTC) #2
bsalomon
https://codereview.chromium.org/21036008/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp File src/gpu/GrAAHairLinePathRenderer.cpp (right): https://codereview.chromium.org/21036008/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp#newcode1116 src/gpu/GrAAHairLinePathRenderer.cpp:1116: static const uint32_t gReqDerivMask = SkPath::kCubic_SegmentMask | I think ...
7 years, 4 months ago (2013-07-31 18:48:33 UTC) #3
egdaniel
https://codereview.chromium.org/21036008/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp File src/gpu/GrAAHairLinePathRenderer.cpp (right): https://codereview.chromium.org/21036008/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp#newcode1116 src/gpu/GrAAHairLinePathRenderer.cpp:1116: static const uint32_t gReqDerivMask = SkPath::kCubic_SegmentMask | On 2013/07/31 ...
7 years, 4 months ago (2013-07-31 19:58:32 UTC) #4
egdaniel
https://codereview.chromium.org/21036008/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp File src/gpu/GrAAHairLinePathRenderer.cpp (right): https://codereview.chromium.org/21036008/diff/1/src/gpu/GrAAHairLinePathRenderer.cpp#newcode1116 src/gpu/GrAAHairLinePathRenderer.cpp:1116: static const uint32_t gReqDerivMask = SkPath::kCubic_SegmentMask | On 2013/07/31 ...
7 years, 4 months ago (2013-07-31 19:58:32 UTC) #5
egdaniel
Changed the canDrawPath to look specifically for if line or has deriv support. Hopefully fixed ...
7 years, 4 months ago (2013-08-01 13:52:50 UTC) #6
bsalomon
lgtm I had a spell checker installed in VS 2010 and realized that I can ...
7 years, 4 months ago (2013-08-01 13:58:48 UTC) #7
egdaniel
7 years, 4 months ago (2013-08-01 17:09:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r10487 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698