Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2103573002: Use const variable instead of using a macro to store a constant. (Closed)

Created:
4 years, 5 months ago by jaepark
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use const variables instead of using macros to store constants. Committed: https://crrev.com/d83f822fafbf12f309e3ca04c7275e3ecd4aa456 Cr-Commit-Position: refs/heads/master@{#402324}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 2 chunks +18 lines, -18 lines 4 comments Download

Messages

Total messages: 15 (6 generated)
jaepark
4 years, 5 months ago (2016-06-27 21:21:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103573002/1
4 years, 5 months ago (2016-06-27 21:23:46 UTC) #4
Lei Zhang
Please fix the grammar in the CL description. https://codereview.chromium.org/2103573002/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/2103573002/diff/1/pdf/pdfium/pdfium_engine.cc#newcode98 pdf/pdfium/pdfium_engine.cc:98: const ...
4 years, 5 months ago (2016-06-27 21:28:07 UTC) #5
jaepark
https://codereview.chromium.org/2103573002/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/2103573002/diff/1/pdf/pdfium/pdfium_engine.cc#newcode98 pdf/pdfium/pdfium_engine.cc:98: const int32_t kMaxProgressivePaintTimeMs = 300; On 2016/06/27 21:28:07, Lei ...
4 years, 5 months ago (2016-06-27 21:31:36 UTC) #7
Lei Zhang
lgtm
4 years, 5 months ago (2016-06-27 21:31:59 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 22:49:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103573002/1
4 years, 5 months ago (2016-06-27 22:53:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 23:05:06 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 23:06:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d83f822fafbf12f309e3ca04c7275e3ecd4aa456
Cr-Commit-Position: refs/heads/master@{#402324}

Powered by Google App Engine
This is Rietveld 408576698