Issue 2103443004: Implement IJS_Runtime::Destroy().

Issue 2103443004: Implement IJS_Runtime::Destroy(). (Closed)

Created:
4 years, 5 months ago by Lei Zhang

Modified:
4 years, 5 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
pdfium-reviews_googlegroups.com, Tom Sepez

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Implement IJS_Runtime::Destroy(). And call it from FPDF_DestroyLibrary(). Otherwise further attempts to FPDF_InitLibraryWithConfig() can hit fail an assertion in IJS_Runtime::Initialize(). BUG=604587 Committed: https://pdfium.googlesource.com/pdfium/+/2d6dda170d84564f6ca5845ea934a886ac9bf746

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
M	fpdfsdk/fpdfview.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	fpdfsdk/javascript/JS_Runtime_Stub.cpp	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	fpdfsdk/javascript/cjs_runtime.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	fpdfsdk/javascript/ijs_runtime.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	testing/js_embedder_test.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103443004/20001

4 years, 5 months ago (2016-06-28 14:38:54 UTC) #5

commit-bot: I haz the power

4 years, 5 months ago (2016-06-28 14:39:13 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/2d6dda170d84564f6ca5845ea934a886ac9b...