testing/js_embedder_test.cpp - Issue 2103443004: Implement IJS_Runtime::Destroy().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/js_embedder_test.cpp

Issue 2103443004: Implement IJS_Runtime::Destroy(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Fix no V8 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/js_embedder_test.cpp

diff --git a/testing/js_embedder_test.cpp b/testing/js_embedder_test.cpp

index bdd1573a61029a73d191f516f9cc0d8fa0b98ea6..5927d89af592ba2188fe9f78fdd793921c9bf34c 100644

--- a/testing/js_embedder_test.cpp

+++ b/testing/js_embedder_test.cpp

@@ -28,7 +28,6 @@ void JSEmbedderTest::SetUp() {

void JSEmbedderTest::TearDown() {

FXJS_ReleaseRuntime(m_pIsolate, &m_pPersistentContext, &m_StaticObjects);

m_pPersistentContext.Reset();

- FXJS_Release();

EmbedderTest::TearDown();

m_pIsolate->Dispose();

m_pIsolate = nullptr;

« no previous file with comments | « fpdfsdk/javascript/ijs_runtime.h ('k') | no next file » | no next file with comments »