Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: src/compiler/pipeline.cc

Issue 2103363004: [turbofan] Run representation selection without the Typer decorator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index d5920009115d34a8ec9220b49868b75897e378ac..73d484ba197d78b1507d65e7109226b0420f3d0d 100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -1444,12 +1444,14 @@ bool PipelineImpl::CreateGraph() {
Run<EscapeAnalysisPhase>();
RunPrintAndVerify("Escape Analysed");
}
-
- // Select representations.
- Run<RepresentationSelectionPhase>();
- RunPrintAndVerify("Representations selected", true);
}
+ // Select representations. This has to run w/o the Typer decorator, because
+ // we cannot compute meaningful types anyways, and the computed types might
+ // even conflict with the representation/truncation logic.
+ Run<RepresentationSelectionPhase>();
+ RunPrintAndVerify("Representations selected", true);
+
#ifdef DEBUG
// From now on it is invalid to look at types on the nodes, because:
//
« no previous file with comments | « no previous file | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698