| Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
|
| diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
|
| index 02bcfdd2e062c0277b689fa8b3208d63253c2f8d..032c5782e8d81bcb3d6309faed6cb665fc8929b8 100644
|
| --- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
|
| +++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
|
| @@ -36,11 +36,14 @@ void AutofillPopupViewAndroid::Show() {
|
| ui::ViewAndroid* view_android = controller_->container_view();
|
|
|
| DCHECK(view_android);
|
| + popup_view_ = view_android->AcquireAnchorView();
|
| + if (popup_view_.is_null())
|
| + return;
|
|
|
| java_object_.Reset(Java_AutofillPopupBridge_create(
|
| - env, reinterpret_cast<intptr_t>(this),
|
| - view_android->GetWindowAndroid()->GetJavaObject().obj(),
|
| - view_android->GetViewAndroidDelegate().obj()));
|
| + env, popup_view_.view().obj(), controller_->element_bounds().width(),
|
| + reinterpret_cast<intptr_t>(this),
|
| + view_android->GetWindowAndroid()->GetJavaObject().obj()));
|
|
|
| UpdateBoundsAndRedrawPopup();
|
| }
|
| @@ -48,19 +51,25 @@ void AutofillPopupViewAndroid::Show() {
|
| void AutofillPopupViewAndroid::Hide() {
|
| controller_ = NULL;
|
| JNIEnv* env = base::android::AttachCurrentThread();
|
| - Java_AutofillPopupBridge_dismiss(env, java_object_.obj());
|
| + if (!java_object_.is_null()) {
|
| + Java_AutofillPopupBridge_dismiss(env, java_object_.obj());
|
| + } else {
|
| + // Hide() should delete |this| either via Java dismiss or directly.
|
| + delete this;
|
| + }
|
| }
|
|
|
| void AutofillPopupViewAndroid::UpdateBoundsAndRedrawPopup() {
|
| - JNIEnv* env = base::android::AttachCurrentThread();
|
| - Java_AutofillPopupBridge_setAnchorRect(
|
| - env,
|
| - java_object_.obj(),
|
| - controller_->element_bounds().x(),
|
| - controller_->element_bounds().y(),
|
| - controller_->element_bounds().width(),
|
| - controller_->element_bounds().height());
|
| + if (java_object_.is_null() || popup_view_.is_null())
|
| + return;
|
|
|
| + ui::ViewAndroid* view_android = controller_->container_view();
|
| +
|
| + DCHECK(view_android);
|
| + view_android->SetAnchorRect(popup_view_.view(),
|
| + controller_->element_bounds());
|
| +
|
| + JNIEnv* env = base::android::AttachCurrentThread();
|
| size_t count = controller_->GetLineCount();
|
| ScopedJavaLocalRef<jobjectArray> data_array =
|
| Java_AutofillPopupBridge_createAutofillSuggestionArray(env, count);
|
| @@ -106,7 +115,7 @@ void AutofillPopupViewAndroid::DeletionRequested(
|
| JNIEnv* env,
|
| const JavaParamRef<jobject>& obj,
|
| jint list_index) {
|
| - if (!controller_)
|
| + if (!controller_ || java_object_.is_null())
|
| return;
|
|
|
| base::string16 confirmation_title, confirmation_body;
|
|
|