Factor out ContentViewAndroidDelegate

android_webview/native/aw_autofill_client.h

Index: android_webview/native/aw_autofill_client.h
diff --git a/android_webview/native/aw_autofill_client.h b/android_webview/native/aw_autofill_client.h
index ca4119d62f4e8fe3795d351010d4e283bfa3e0ad..d090d33e9435e667a316292fb5aef2a5f9751c85 100644
--- a/android_webview/native/aw_autofill_client.h
+++ b/android_webview/native/aw_autofill_client.h
@@ -15,6 +15,7 @@
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service_factory.h"
 #include "content/public/browser/web_contents_user_data.h"
+#include "ui/android/view_android.h"
 
 namespace autofill {
 class AutofillMetrics;
@@ -102,6 +103,8 @@ class AwAutofillClient : public autofill::AutofillClient,
   bool ShouldShowSigninPromo() override;
   void StartSigninFlow() override;
 
+  void Dismissed(JNIEnv* env,
+                 const base::android::JavaParamRef<jobject>& obj);
   void SuggestionSelected(JNIEnv* env,
                           const base::android::JavaParamRef<jobject>& obj,
                           jint position);
@@ -120,6 +123,8 @@ class AwAutofillClient : public autofill::AutofillClient,
   bool save_form_data_;
   JavaObjectWeakGlobalRef java_ref_;
 
+  ui::ViewAndroid::ScopedAnchorView anchor_view_;

[boliu, 2016/07/25 22:15:26]

another gc root, what's the lifetime guanratee here that this is ok and won't
leak things?

[no sievers, 2016/07/25 22:24:40]

For the View or the Delegate?

The whole point is that it doesn't matter. That's what the ViewAndroidDelegate
is for.
WebView now implements this internally where it can either use a WeakRef or
reset the reference when necessary.
Holding on to the Delegate should be harmless.

[boliu, 2016/07/25 22:29:24]

View, which has parent references back to the whole view tree, while attached
anyway.

[boliu, 2016/07/25 22:33:34]

Actually delegate too. The delegate is holding strongly onto the anchor views,
and delegate is held strongly from here too.

Maybe a better pattern is this:
ViewAndroidDelegate holds weakly onto (anchor|container)views
Pass ViewAndroidDelegate through jni
Java code gets the views from ViewAndroidDelegate

Safer as there is no possibility of leak then in webview. Could even write a gc
test.

+
   // The current Autofill query values.
   std::vector<autofill::Suggestion> suggestions_;
   base::WeakPtr<autofill::AutofillPopupDelegate> delegate_;