Factor out ContentViewAndroidDelegate

android_webview/native/aw_autofill_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ANDROID_WEBVIEW_NATIVE_AW_AUTOFILL_CLIENT_H_
 #define ANDROID_WEBVIEW_NATIVE_AW_AUTOFILL_CLIENT_H_
 
 #include <jni.h>
 #include <vector>
 
 #include "base/android/jni_weak_ref.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "components/autofill/core/browser/autofill_client.h"
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service_factory.h"
 #include "content/public/browser/web_contents_user_data.h"
+#include "ui/android/view_android.h"
 
 namespace autofill {
 class AutofillMetrics;
 class AutofillPopupDelegate;
 class CardUnmaskDelegate;
 class CreditCard;
 class FormStructure;
 class PasswordGenerator;
 class PersonalDataManager;
 struct FormData;
@@ skipping 67 matching lines @@
   void PropagateAutofillPredictions(
       content::RenderFrameHost* rfh,
       const std::vector<autofill::FormStructure*>& forms) override;
   void DidFillOrPreviewField(const base::string16& autofilled_value,
                              const base::string16& profile_full_name) override;
   void OnFirstUserGestureObserved() override;
   bool IsContextSecure(const GURL& form_origin) override;
   bool ShouldShowSigninPromo() override;
   void StartSigninFlow() override;
 
+  void Dismissed(JNIEnv* env,
+                 const base::android::JavaParamRef<jobject>& obj);
   void SuggestionSelected(JNIEnv* env,
                           const base::android::JavaParamRef<jobject>& obj,
                           jint position);
 
  private:
   AwAutofillClient(content::WebContents* web_contents);
   friend class content::WebContentsUserData<AwAutofillClient>;
 
   void ShowAutofillPopupImpl(
       const gfx::RectF& element_bounds,
       bool is_rtl,
       const std::vector<autofill::Suggestion>& suggestions);
 
   // The web_contents associated with this delegate.
   content::WebContents* web_contents_;
   bool save_form_data_;
   JavaObjectWeakGlobalRef java_ref_;
 
+  ui::ViewAndroid::ScopedAnchorView anchor_view_;

[boliu, 2016/07/25 22:15:26]

another gc root, what's the lifetime guanratee here that this is ok and won't
leak things?

[no sievers, 2016/07/25 22:24:40]

For the View or the Delegate?

The whole point is that it doesn't matter. That's what the ViewAndroidDelegate
is for.
WebView now implements this internally where it can either use a WeakRef or
reset the reference when necessary.
Holding on to the Delegate should be harmless.

[boliu, 2016/07/25 22:29:24]

View, which has parent references back to the whole view tree, while attached
anyway.

[boliu, 2016/07/25 22:33:34]

Actually delegate too. The delegate is holding strongly onto the anchor views,
and delegate is held strongly from here too.

Maybe a better pattern is this:
ViewAndroidDelegate holds weakly onto (anchor|container)views
Pass ViewAndroidDelegate through jni
Java code gets the views from ViewAndroidDelegate

Safer as there is no possibility of leak then in webview. Could even write a gc
test.

+
   // The current Autofill query values.
   std::vector<autofill::Suggestion> suggestions_;
   base::WeakPtr<autofill::AutofillPopupDelegate> delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(AwAutofillClient);
 };
 
 bool RegisterAwAutofillClient(JNIEnv* env);
 
 }  // namespace android_webview
 
 #endif  // ANDROID_WEBVIEW_NATIVE_AW_AUTOFILL_CLIENT_H_