Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: components/data_reduction_proxy/proto/client_config.proto

Issue 2103223002: Adding version info to the client config request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removing leftover headers Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/proto/client_config.proto
diff --git a/components/data_reduction_proxy/proto/client_config.proto b/components/data_reduction_proxy/proto/client_config.proto
index 98cc093e0d4b565d1ce9fd9d9a305ab70c243761..6d89ce233126fdb05da6121e8076a2bf29fe6f98 100644
--- a/components/data_reduction_proxy/proto/client_config.proto
+++ b/components/data_reduction_proxy/proto/client_config.proto
@@ -102,11 +102,46 @@ message ProxyServer {
// The host name for the proxy server.
optional string host = 2;
// The port number for the proxy server.
optional int32 port = 3;
}
// Request object to create a client configuration object.
message CreateClientConfigRequest {
// A previous per-session key that was assigned by the service.
optional string session_key = 1;
+
+ // Build version information.
+ optional VersionInfo version_info = 2;
}
+
+// Build version information.
+message VersionInfo {
+ // The production channel.
+ enum Channel {
+ // The channel is unspecififed.
tbansal1 2016/06/28 21:32:15 s/unspecififed/unspecified/
RyanSturm 2016/06/28 22:22:14 Acknowledged.
+ UNKNOWN = 0;
+ // The channel is canary.
+ CANARY = 1;
+ // The channel is dev.
+ DEV = 2;
+ // The channel is beta.
+ BETA = 3;
+ // The channel is stable.
+ STABLE = 4;
+ }
+
+ // The production channel.
+ optional Channel channel = 1;
+
+ // The version number, e.g. "6.0.490.1".
+ optional string version_number = 2;
buettner 2016/06/28 20:52:01 I think channel/build/patch is enough. And client_
tbansal1 2016/06/28 21:32:15 OS may be important since some experiments may be
RyanSturm 2016/06/28 22:22:14 Done.
RyanSturm 2016/06/28 22:22:14 Done.
+
+ // The product name, e.g. "Chromium" or "Google Chrome".
+ optional string product_name = 3;
+
+ // The OS type, e.g. "Windows", "Linux", etc.
+ optional string os_type = 4;
+
+ // Whether this is an "official" release of the current version
+ optional bool is_official_build = 5;
+}

Powered by Google App Engine
This is Rietveld 408576698