Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: components/data_reduction_proxy/proto/client_config.proto

Issue 2103223002: Adding version info to the client config request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removing leftover headers Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 syntax = "proto2"; 5 syntax = "proto2";
6 6
7 option optimize_for = LITE_RUNTIME; 7 option optimize_for = LITE_RUNTIME;
8 8
9 package data_reduction_proxy; 9 package data_reduction_proxy;
10 10
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 // The host name for the proxy server. 102 // The host name for the proxy server.
103 optional string host = 2; 103 optional string host = 2;
104 // The port number for the proxy server. 104 // The port number for the proxy server.
105 optional int32 port = 3; 105 optional int32 port = 3;
106 } 106 }
107 107
108 // Request object to create a client configuration object. 108 // Request object to create a client configuration object.
109 message CreateClientConfigRequest { 109 message CreateClientConfigRequest {
110 // A previous per-session key that was assigned by the service. 110 // A previous per-session key that was assigned by the service.
111 optional string session_key = 1; 111 optional string session_key = 1;
112
113 // Build version information.
114 optional VersionInfo version_info = 2;
112 } 115 }
116
117 // Build version information.
118 message VersionInfo {
119 // The production channel.
120 enum Channel {
121 // The channel is unspecififed.
tbansal1 2016/06/28 21:32:15 s/unspecififed/unspecified/
RyanSturm 2016/06/28 22:22:14 Acknowledged.
122 UNKNOWN = 0;
123 // The channel is canary.
124 CANARY = 1;
125 // The channel is dev.
126 DEV = 2;
127 // The channel is beta.
128 BETA = 3;
129 // The channel is stable.
130 STABLE = 4;
131 }
132
133 // The production channel.
134 optional Channel channel = 1;
135
136 // The version number, e.g. "6.0.490.1".
137 optional string version_number = 2;
buettner 2016/06/28 20:52:01 I think channel/build/patch is enough. And client_
tbansal1 2016/06/28 21:32:15 OS may be important since some experiments may be
RyanSturm 2016/06/28 22:22:14 Done.
RyanSturm 2016/06/28 22:22:14 Done.
138
139 // The product name, e.g. "Chromium" or "Google Chrome".
140 optional string product_name = 3;
141
142 // The OS type, e.g. "Windows", "Linux", etc.
143 optional string os_type = 4;
144
145 // Whether this is an "official" release of the current version
146 optional bool is_official_build = 5;
147 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698