Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2103053002: Cherry-pick buildbot 95deef27d7c531ead19e0ac86a9aa1546d4ee7f9: (Closed)

Created:
4 years, 5 months ago by dsansome
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@buildbot-version-2
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Cherry-pick buildbot 95deef27d7c531ead19e0ac86a9aa1546d4ee7f9: Re-run queries after certain OperationalErrors Sometimes malformed SQL can generate an OperationalError, so this looks at the message itself. It's unclear how this will work with localization. The code uses an exponential backoff algorithm (with a relatively small multiplier), and will retry for a day, which seems a reasonable get-the-db-server-fixed time. Fixes #2005. Hoepfully for good! BUG=620572 Committed: https://chromium.googlesource.com/chromium/tools/build/+/8d24f5663861a7ae00e544f96e5c2e35787ecf4d

Patch Set 1 #

Patch Set 2 : Disable the test again #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -51 lines) Patch
M third_party/buildbot_8_4p1/buildbot/db/pool.py View 2 chunks +74 lines, -50 lines 1 comment Download
M third_party/buildbot_8_4p1/buildbot/test/unit/test_db_pool.py View 1 2 chunks +46 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
dsansome
I ran this Stress test with and without the patch to pool.py, and confirmed the ...
4 years, 5 months ago (2016-06-28 08:08:08 UTC) #3
ghost stip (do not use)
lgtm https://codereview.chromium.org/2103053002/diff/20001/third_party/buildbot_8_4p1/buildbot/db/pool.py File third_party/buildbot_8_4p1/buildbot/db/pool.py (right): https://codereview.chromium.org/2103053002/diff/20001/third_party/buildbot_8_4p1/buildbot/db/pool.py#newcode92 third_party/buildbot_8_4p1/buildbot/db/pool.py:92: # Try about 170 times over the space ...
4 years, 5 months ago (2016-07-01 01:30:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103053002/20001
4 years, 5 months ago (2016-07-01 04:42:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/build/+/8d24f5663861a7ae00e544f96e5c2e35787ecf4d
4 years, 5 months ago (2016-07-01 04:46:06 UTC) #8
ghost stip (do not use)
4 years, 5 months ago (2016-07-07 20:13:30 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2128953002/ by stip@chromium.org.

The reason for reverting is: possible cause of
https://bugs.chromium.org/p/chromium/issues/detail?id=626354..

Powered by Google App Engine
This is Rietveld 408576698