Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2102003003: Revert "Fix masters_test presubmit_tests by using serialized sqlite access." (Closed)

Created:
4 years, 5 months ago by dsansome
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@buildbot-retry-concurrent
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert 4e7e4672aae819f312c9691544652f251964007f to make multiple connections to sqlite databases again. This is safe after https://codereview.chromium.org/2103053002/ BUG=620572 Committed: https://chromium.googlesource.com/chromium/tools/build/+/312d2566bfcb38bcaa25e93c27d9d862d05c7a8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M third_party/buildbot_8_4p1/buildbot/db/enginestrategy.py View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/master.py View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
dsansome
4 years, 5 months ago (2016-06-28 08:58:40 UTC) #3
ghost stip (do not use)
lgtm
4 years, 5 months ago (2016-07-01 01:30:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102003003/1
4 years, 5 months ago (2016-07-01 04:52:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/312d2566bfcb38bcaa25e93c27d9d862d05c7a8a
4 years, 5 months ago (2016-07-01 04:56:50 UTC) #8
ghost stip (do not use)
4 years, 5 months ago (2016-07-07 16:33:59 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2126033003/ by stip@chromium.org.

The reason for reverting is: possible cause of
https://bugs.chromium.org/p/chromium/issues/detail?id=626354.

Powered by Google App Engine
This is Rietveld 408576698