third_party/WebKit/LayoutTests/editing/execCommand/remove-format-variable-crash.html - Issue 2103043004: Fix EditingStyle::mergeStyle()'s handling of custom properties

Unified Diff: third_party/WebKit/LayoutTests/editing/execCommand/remove-format-variable-crash.html

Issue 2103043004: Fix EditingStyle::mergeStyle()'s handling of custom properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test tweak Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/editing/execCommand/remove-format-variable-crash.html

diff --git a/third_party/WebKit/LayoutTests/editing/execCommand/remove-format-variable-crash.html b/third_party/WebKit/LayoutTests/editing/execCommand/remove-format-variable-crash.html

new file mode 100644

index 0000000000000000000000000000000000000000..da30699f906112aa97b22978862da3c1b185ac83

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/editing/execCommand/remove-format-variable-crash.html

@@ -0,0 +1,20 @@

+<!doctype html>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script>

+document.documentElement.contentEditable="true";

+document.documentElement.appendChild(document.createElement('table'));

+eAcronym = document.createElement('acronym');

+document.documentElement.appendChild(eAcronym);

+document.documentElement.appendChild(document.createElement('keygen'));

+newElem = document.createElement('figure');

+newElem.style.cssText = '--AAAA: var(--BBBB)';

yosin_UTC9 2016/06/30 04:07:38 I think this line should not affect test since it

Timothy Loh 2016/06/30 04:16:42 This is necessary for the crash, since this result

+document.documentElement.appendChild(newElem);

+eCite = document.createElement('cite');

+eCite.style.cssText = 'float: var(--CCCC)';

yosin_UTC9 2016/06/30 04:07:38 I think this line should not affect test since it

Timothy Loh 2016/06/30 04:16:42 Seems to be required to repro the crash.

+eAcronym.appendChild(eCite);

+eCite.appendChild(document.createElement('marquee'));

+document.execCommand('SelectAll', 'false', 'true');

yosin_UTC9 2016/06/30 04:07:38 nit: you don't need to have |, 'false', 'true'|.

Timothy Loh 2016/06/30 04:16:42 removed

+document.execCommand('RemoveFormat', 'true', 'true');

yosin_UTC9 2016/06/30 04:07:38 nit: you don't need to have |, 'true', 'true'|.

Timothy Loh 2016/06/30 04:16:42 removed

+test(() => {}, "This test passes if it doesn't crash.");

+</script>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/StylePropertySet.cpp » ('j') | no next file with comments »