third_party/WebKit/LayoutTests/editing/execCommand/remove-format-variable-crash.html - Issue 2103043004: Fix EditingStyle::mergeStyle()'s handling of custom properties

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/execCommand/remove-format-variable-crash.html

Issue 2103043004: Fix EditingStyle::mergeStyle()'s handling of custom properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test tweak Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 document.documentElement.contentEditable="true";

	6 document.documentElement.appendChild(document.createElement('table'));

	7 eAcronym = document.createElement('acronym');

	8 document.documentElement.appendChild(eAcronym);

	9 document.documentElement.appendChild(document.createElement('keygen'));

	10 newElem = document.createElement('figure');

	11 newElem.style.cssText = '--AAAA: var(--BBBB)';
	yosin_UTC9 2016/06/30 04:07:38 I think this line should not affect test since it I think this line should not affect test since it is meaningless style. Timothy Loh 2016/06/30 04:16:42 This is necessary for the crash, since this result Show quoted text On 2016/06/30 04:07:38, Yosi_UTC9 wrote: > I think this line should not affect test since it is meaningless style. This is necessary for the crash, since this results in the declaration which mergeStyle doesn't correctly handle.
	12 document.documentElement.appendChild(newElem);

	13 eCite = document.createElement('cite');

	14 eCite.style.cssText = 'float: var(--CCCC)';
	yosin_UTC9 2016/06/30 04:07:38 I think this line should not affect test since it I think this line should not affect test since it is meaningless style. Timothy Loh 2016/06/30 04:16:42 Seems to be required to repro the crash. Show quoted text On 2016/06/30 04:07:38, Yosi_UTC9 wrote: > I think this line should not affect test since it is meaningless style. Seems to be required to repro the crash.
	15 eAcronym.appendChild(eCite);

	16 eCite.appendChild(document.createElement('marquee'));

	17 document.execCommand('SelectAll', 'false', 'true');
	yosin_UTC9 2016/06/30 04:07:38 nit: you don't need to have \|, 'false', 'true'\|. nit: you don't need to have \|, 'false', 'true'\|. Timothy Loh 2016/06/30 04:16:42 removed Show quoted text On 2016/06/30 04:07:38, Yosi_UTC9 wrote: > nit: you don't need to have \|, 'false', 'true'\|. removed
	18 document.execCommand('RemoveFormat', 'true', 'true');
	yosin_UTC9 2016/06/30 04:07:38 nit: you don't need to have \|, 'true', 'true'\|. nit: you don't need to have \|, 'true', 'true'\|. Timothy Loh 2016/06/30 04:16:42 removed Show quoted text On 2016/06/30 04:07:38, Yosi_UTC9 wrote: > nit: you don't need to have \|, 'true', 'true'\|. removed
	19 test(() => {}, "This test passes if it doesn't crash.");

	20 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/StylePropertySet.cpp » ('j') | no next file with comments »