Remove legacy PDF JSON interface.

Remove legacy PDF JSON interface.

Now that the PDF plug-in supports native accessibility, we can remove
the accessibility JSON interface and the ChromeVox code that calls it.

BUG=54724
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a41883ee67ef28c0bd69aeae32f8562cdac427b3
Cr-Commit-Position: refs/heads/master@{#403213}

[dmazzoni, 2016-06-28 16:26:12]

Description was changed from

==========
Remove legacy PDF JSON interface.

Now that the PDF plug-in supports native accessibility, we can remove
the accessibility JSON interface and the ChromeVox code that calls it.

BUG=54724
==========

to

==========
Remove legacy PDF JSON interface.

Now that the PDF plug-in supports native accessibility, we can remove
the accessibility JSON interface and the ChromeVox code that calls it.

BUG=54724
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-06-28 16:26:41]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org, raymes@chromium.org

[dmazzoni, 2016-06-28 16:26:42]

raymes for pdf
dtseng for chromevox

[David Tseng, 2016-06-28 19:53:30]

lgtm

https://codereview.chromium.org/2103043003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 (right):

https://codereview.chromium.org/2103043003/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2:38: "*.pdf"
Have you tested this with an iframe src'ed to a pdf? I don't think we handle
that case.

https://codereview.chromium.org/2103043003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
(left):

https://codereview.chromium.org/2103043003/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2357:
Unable to access accessible text from copy-protected PDF.
Curious, do we now handle this case?

[raymes, 2016-06-29 00:10:43]

lgtm for 
chrome/browser/resources/pdf/*
chrome/test/data/pdf/basic_plugin_test.js
pdf/out_of_process_instance.cc

but defer to thestig for the rest of pdf/pdfium/*

[dmazzoni, 2016-06-29 17:28:02]

dmazzoni@chromium.org changed reviewers:
+ thestig@chromium.org

[dmazzoni, 2016-06-29 17:28:02]

+thestig for pdf/

[Lei Zhang, 2016-06-29 17:58:56]

lgtm

[dmazzoni, 2016-06-29 20:50:21]

https://codereview.chromium.org/2103043003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 (right):

https://codereview.chromium.org/2103043003/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2:38: "*.pdf"
On 2016/06/28 19:53:30, David Tseng wrote:
> Have you tested this with an iframe src'ed to a pdf? I don't think we handle
> that case.

Good catch. I changed the whitelisting rules so that it checks the current
root for compat whitelisting, not just the top level root. It's obviously not
perfect since Classic won't automatically move focus into the plug-in, but
if you Tab into it, it switches to Compat now.

https://codereview.chromium.org/2103043003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
(left):

https://codereview.chromium.org/2103043003/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:2357:
Unable to access accessible text from copy-protected PDF.
On 2016/06/28 19:53:30, David Tseng wrote:
> Curious, do we now handle this case?

No, it's treated the same. The message doesn't belong as part of ChromeVox
anymore, maybe we need it as part of components/pdf now.

[dmazzoni, 2016-06-29 20:50:29]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-06-29 20:50:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, raymes@chromium.org, dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2103043003/#ps60001
(title: "Fix pdf in iframe")

[commit-bot: I haz the power, 2016-06-29 20:51:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 20:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 20:56:28]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dmazzoni, 2016-06-29 21:17:37]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-06-29 21:17:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, raymes@chromium.org, dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2103043003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-29 21:18:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 21:50:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 21:50:07]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2016-06-29 21:57:04]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-06-29 21:57:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, raymes@chromium.org, dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2103043003/#ps100001
(title: "Fix typo after merge")

[commit-bot: I haz the power, 2016-06-29 21:59:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 22:58:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 22:58:29]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2016-06-30 16:54:41]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-06-30 16:55:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 17:44:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-30 17:45:12]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 17:49:42]

Description was changed from

==========
Remove legacy PDF JSON interface.

Now that the PDF plug-in supports native accessibility, we can remove
the accessibility JSON interface and the ChromeVox code that calls it.

BUG=54724
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove legacy PDF JSON interface.

Now that the PDF plug-in supports native accessibility, we can remove
the accessibility JSON interface and the ChromeVox code that calls it.

BUG=54724
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a41883ee67ef28c0bd69aeae32f8562cdac427b3
Cr-Commit-Position: refs/heads/master@{#403213}
==========

[commit-bot: I haz the power, 2016-06-30 17:49:44]

Patchset 6 (id:??) landed as
https://crrev.com/a41883ee67ef28c0bd69aeae32f8562cdac427b3
Cr-Commit-Position: refs/heads/master@{#403213}