Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1527)

Unified Diff: pdf/out_of_process_instance.cc

Issue 2103043003: Remove legacy PDF JSON interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo after merge Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/pdf/basic_plugin_test.js ('k') | pdf/pdf_engine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/out_of_process_instance.cc
diff --git a/pdf/out_of_process_instance.cc b/pdf/out_of_process_instance.cc
index e766b7c5d558d334ba0e84e6923084a75ad22ef4..ae680bde0ef41160c4487df8622cdda65e16f750 100644
--- a/pdf/out_of_process_instance.cc
+++ b/pdf/out_of_process_instance.cc
@@ -13,8 +13,6 @@
#include <math.h>
#include <list>
-#include "base/json/json_reader.h"
-#include "base/json/json_writer.h"
#include "base/logging.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
@@ -51,11 +49,6 @@ const char kChromePrint[] = "chrome://print/";
const char kChromeExtension[] =
"chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai";
-// Dictionary Value key names for the document accessibility info
-const char kAccessibleNumberOfPages[] = "numberOfPages";
-const char kAccessibleLoaded[] = "loaded";
-const char kAccessibleCopyable[] = "copyable";
-
// Constants used in handling postMessage() messages.
const char kType[] = "type";
// Viewport message arguments. (Page -> Plugin).
@@ -106,12 +99,6 @@ const char kJSPreviewPageIndex[] = "index";
const char kJSSetScrollPositionType[] = "setScrollPosition";
const char kJSPositionX[] = "x";
const char kJSPositionY[] = "y";
-// Request accessibility JSON data (Page -> Plugin)
-const char kJSGetAccessibilityJSONType[] = "getAccessibilityJSON";
-const char kJSAccessibilityPageNumber[] = "page";
-// Reply with accessibility JSON data (Plugin -> Page)
-const char kJSGetAccessibilityJSONReplyType[] = "getAccessibilityJSONReply";
-const char kJSAccessibilityJSON[] = "json";
// Cancel the stream URL request (Plugin -> Page)
const char kJSCancelStreamUrlType[] = "cancelStreamUrl";
// Navigate to the given URL (Plugin -> Page)
@@ -461,27 +448,6 @@ void OutOfProcessInstance::HandleMessage(const pp::Var& message) {
dict.Get(pp::Var(kJSPreviewPageIndex)).is_int()) {
ProcessPreviewPageInfo(dict.Get(pp::Var(kJSPreviewPageUrl)).AsString(),
dict.Get(pp::Var(kJSPreviewPageIndex)).AsInt());
- } else if (type == kJSGetAccessibilityJSONType) {
- pp::VarDictionary reply;
- reply.Set(pp::Var(kType), pp::Var(kJSGetAccessibilityJSONReplyType));
- if (dict.Get(pp::Var(kJSAccessibilityPageNumber)).is_int()) {
- int page = dict.Get(pp::Var(kJSAccessibilityPageNumber)).AsInt();
- reply.Set(pp::Var(kJSAccessibilityJSON),
- pp::Var(engine_->GetPageAsJSON(page)));
- } else {
- base::DictionaryValue node;
- node.SetInteger(kAccessibleNumberOfPages, engine_->GetNumberOfPages());
- node.SetBoolean(kAccessibleLoaded,
- document_load_state_ != LOAD_STATE_LOADING);
- bool has_permissions =
- engine_->HasPermission(PDFEngine::PERMISSION_COPY) ||
- engine_->HasPermission(PDFEngine::PERMISSION_COPY_ACCESSIBLE);
- node.SetBoolean(kAccessibleCopyable, has_permissions);
- std::string json;
- base::JSONWriter::Write(node, &json);
- reply.Set(pp::Var(kJSAccessibilityJSON), pp::Var(json));
- }
- PostMessage(reply);
} else if (type == kJSStopScrollingType) {
stop_scrolling_ = true;
} else if (type == kJSGetSelectedTextType) {
« no previous file with comments | « chrome/test/data/pdf/basic_plugin_test.js ('k') | pdf/pdf_engine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698