Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: media/cast/transport/cast_transport_sender_impl.h

Issue 210303003: Cast: Remove LoggingStats in favor of event subscribers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/transport/cast_transport_sender.h ('k') | media/cast/transport/cast_transport_sender_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/transport/cast_transport_sender_impl.h
diff --git a/media/cast/transport/cast_transport_sender_impl.h b/media/cast/transport/cast_transport_sender_impl.h
index c8ead5e0236fa1964ad955823fba49b5cece6214..dd812174cfbee31b7ed1aafe936887080312e9cf 100644
--- a/media/cast/transport/cast_transport_sender_impl.h
+++ b/media/cast/transport/cast_transport_sender_impl.h
@@ -38,7 +38,6 @@ class CastTransportSenderImpl : public CastTransportSender {
net::NetLog* net_log,
base::TickClock* clock,
const net::IPEndPoint& remote_end_point,
- const CastLoggingConfig& logging_config,
const CastTransportStatusCallback& status_callback,
const BulkRawEventsCallback& raw_events_callback,
base::TimeDelta raw_events_callback_interval,
@@ -81,9 +80,8 @@ class CastTransportSenderImpl : public CastTransportSender {
const CastTransportRtpStatistics& callback) OVERRIDE;
private:
- // If raw events logging is enabled, this is called periodically.
- // Calls |raw_events_callback_| with events collected by |event_subscriber_|
- // since last call.
+ // If |raw_events_callback_| is non-null, calls it with events collected
+ // by |event_subscriber_| since last call.
void SendRawEvents();
base::TickClock* clock_; // Not owned by this class.
@@ -97,7 +95,7 @@ class CastTransportSenderImpl : public CastTransportSender {
scoped_ptr<TransportAudioSender> audio_sender_;
scoped_ptr<TransportVideoSender> video_sender_;
- // This is non-null iff raw events logging is enabled.
+ // This is non-null iff |raw_events_callback_| is non-null.
scoped_ptr<SimpleEventSubscriber> event_subscriber_;
base::RepeatingTimer<CastTransportSenderImpl> raw_events_timer_;
« no previous file with comments | « media/cast/transport/cast_transport_sender.h ('k') | media/cast/transport/cast_transport_sender_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698