Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: media/cast/transport/cast_transport_sender_impl.cc

Issue 210303003: Cast: Remove LoggingStats in favor of event subscribers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/transport/cast_transport_sender_impl.cc
diff --git a/media/cast/transport/cast_transport_sender_impl.cc b/media/cast/transport/cast_transport_sender_impl.cc
index 1157fff2971f257265b5a3ecc9b899618ad2384e..ba97a96e9d9e95457fc36649bdecd54c6811e7b1 100644
--- a/media/cast/transport/cast_transport_sender_impl.cc
+++ b/media/cast/transport/cast_transport_sender_impl.cc
@@ -16,7 +16,6 @@ scoped_ptr<CastTransportSender> CastTransportSender::Create(
net::NetLog* net_log,
base::TickClock* clock,
const net::IPEndPoint& remote_end_point,
- const CastLoggingConfig& logging_config,
const CastTransportStatusCallback& status_callback,
const BulkRawEventsCallback& raw_events_callback,
base::TimeDelta raw_events_callback_interval,
@@ -25,7 +24,6 @@ scoped_ptr<CastTransportSender> CastTransportSender::Create(
new CastTransportSenderImpl(net_log,
clock,
remote_end_point,
- logging_config,
status_callback,
raw_events_callback,
raw_events_callback_interval,
@@ -37,7 +35,6 @@ CastTransportSenderImpl::CastTransportSenderImpl(
net::NetLog* net_log,
base::TickClock* clock,
const net::IPEndPoint& remote_end_point,
- const CastLoggingConfig& logging_config,
const CastTransportStatusCallback& status_callback,
const BulkRawEventsCallback& raw_events_callback,
base::TimeDelta raw_events_callback_interval,
@@ -52,7 +49,7 @@ CastTransportSenderImpl::CastTransportSenderImpl(
net::IPEndPoint(),
remote_end_point,
status_callback)),
- logging_(logging_config),
+ logging_(),
pacer_(clock,
&logging_,
external_transport ? external_transport : transport_.get(),
@@ -60,7 +57,6 @@ CastTransportSenderImpl::CastTransportSenderImpl(
rtcp_builder_(&pacer_),
raw_events_callback_(raw_events_callback) {
if (!raw_events_callback_.is_null()) {
- DCHECK(logging_config.enable_raw_data_collection);
DCHECK(raw_events_callback_interval > base::TimeDelta());
event_subscriber_.reset(new SimpleEventSubscriber);
logging_.AddRawEventSubscriber(event_subscriber_.get());
« no previous file with comments | « media/cast/transport/cast_transport_sender_impl.h ('k') | media/cast/transport/cast_transport_sender_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698