Cast: Remove LoggingStats in favor of event subscribers.

Cast: Remove LoggingStats in favor of event subscribers.

Removed LoggingStats class and replaced them with StatsEventSubscriber.
StatsEventSubscriber differs in that the type of event to listen to
(audio / video / other) is determined at construction. The API to get
the stats map changed as well - caller now passes in an empty map that
will get assigned with the data. These changes are in line with the
EncodingEventSubscriber. The logic to calculate stats remains the same
as LoggingStats, though this will probably change in the future. Stats
can be reset as well via Reset().

In addition since stats gathering now depends on collection of raw
events (which is enabled everywhere), the flag to enable stats
collection in CastLoggingConfig has been removed.

Removed CastLoggingConfig struct - logging is enabled always now.
There are no use cases where it should be disabled.

BUG=353019
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260055

[imcheng, 2014-03-24 22:57:48]

On second thought, I am going to remove CastLoggingConfig in this patch to avoid
changing IPC definitions twice. Will update once it is done.

[imcheng, 2014-03-25 19:12:55]

+hubbe for cast streaming API tests.
+erickung as FYI.

I have removed the CastLoggingConfig struct from cast library. This means
logging is always enabled. PTAL, thanks.

[Alpha Left Google, 2014-03-25 21:15:31]

On 2014/03/25 19:12:55, imcheng1 wrote:
> +hubbe for cast streaming API tests.
> +erickung as FYI.
> 
> I have removed the CastLoggingConfig struct from cast library. This means
> logging is always enabled. PTAL, thanks.

I like this cleanup effort. So LGTM. Please also add hguihot@ so he's aware of
this effort for the receiver.

[imcheng, 2014-03-25 21:34:00]

+hguihot as FYI.
+dcheng for IPC changes.

PTAL, thanks.

[imcheng, 2014-03-25 23:09:24]

-dcheng as he's busy, +tsepez

Tom, can you please take a look at chrome/common/cast_messages.h? Thanks.

[Tom Sepez, 2014-03-26 17:13:17]

On 2014/03/25 23:09:24, imcheng1 wrote:
> -dcheng as he's busy, +tsepez
> 
> Tom, can you please take a look at chrome/common/cast_messages.h? Thanks.
Messages LGTM.

A minor nit: the name StatsEventSubscriber bothers me a little bit in that
"stats" is plural, but "event" is singular, and feels like bad grammar.  Please
don't throw things at me :). Things get muddier when you expand it to
StatisticsEvent because the word Statistics can be either singular (the science
of statistics) or plural (sets of numbers) depending on the context (by contrast
"stats" only means the latter). Where's the damn English major?

[Mark Larson, 2014-03-26 17:43:57]

On 2014/03/26 17:13:17, Tom Sepez wrote:
> On 2014/03/25 23:09:24, imcheng1 wrote:
> > -dcheng as he's busy, +tsepez
> > 
> > Tom, can you please take a look at chrome/common/cast_messages.h? Thanks.
> Messages LGTM.
> 
> A minor nit: the name StatsEventSubscriber bothers me a little bit in that
> "stats" is plural, but "event" is singular, and feels like bad grammar. 
Please
> don't throw things at me :). Things get muddier when you expand it to
> StatisticsEvent because the word Statistics can be either singular (the
science
> of statistics) or plural (sets of numbers) depending on the context (by
contrast
> "stats" only means the latter). Where's the damn English major?

I wouldn't get hung up on it. StatsEventSubscriber seems easy to understand.
What kind of event is it? Most people wouldn't answer "statistic event" in
conversation, they'd say "statistics event".

I don't think it's a violation of grammar.

[imcheng, 2014-03-26 21:54:20]

Ping for hubbe.

[hubbe, 2014-03-27 18:07:14]

lgtm

[imcheng, 2014-03-27 18:21:44]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2014-03-27 18:21:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/imcheng@chromium.org/210303003/120001

[imcheng, 2014-03-27 18:27:05]

The CQ bit was unchecked by imcheng@chromium.org

[imcheng, 2014-03-27 18:27:31]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2014-03-27 18:35:18]

Failed to trigger a try job on win_x64_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2014-03-27 18:35:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/imcheng@chromium.org/210303003/140001

[commit-bot: I haz the power, 2014-03-27 21:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 21:24:48]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[imcheng, 2014-03-27 22:01:44]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2014-03-27 22:02:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/imcheng@chromium.org/210303003/140001

[commit-bot: I haz the power, 2014-03-28 00:24:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 00:24:31]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[imcheng, 2014-03-28 01:20:49]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2014-03-28 01:20:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/imcheng@chromium.org/210303003/140001

[commit-bot: I haz the power, 2014-03-28 01:24:12]

Change committed as 260055