NetworkState cleanup, pass properties to InitialPropertiesReceived

chromeos/network/network_state_unittest.cc

Index: chromeos/network/network_state_unittest.cc
diff --git a/chromeos/network/network_state_unittest.cc b/chromeos/network/network_state_unittest.cc
index 0ccdd198dbd1f0c7f944bf282109e68ee9d3490d..f0b32e2a1153ae09b2fbb589eb96ac1c1c610516 100644
--- a/chromeos/network/network_state_unittest.cc
+++ b/chromeos/network/network_state_unittest.cc
@@ -54,15 +54,20 @@ class NetworkStateTest : public testing::Test {
 
  protected:
   bool SetStringProperty(const std::string& key, const std::string& value) {
-    if (!network_state_.PropertyChanged(key, TestStringValue(value)))
-      return false;
-    network_state_.InitialPropertiesReceived();
-    return true;
+    bool res = network_state_.PropertyChanged(key, TestStringValue(value));
+    properties_.SetStringWithoutPathExpansion(key, value);
+    return res;
+  }
+
+  void SignalInitialPropertiesReceived() {

[pneubeck (no reviews), 2013/07/29 19:13:25]

If InitialPropertiesReceived returns a bool, then it should be check in the test
too.

[stevenjb, 2013/07/29 20:25:47]

Done.

+    network_state_.InitialPropertiesReceived(properties_);
   }
 
   NetworkState network_state_;
 
  private:
+  base::DictionaryValue properties_;
+
   DISALLOW_COPY_AND_ASSIGN(NetworkStateTest);
 };
 
@@ -97,6 +102,7 @@ TEST_F(NetworkStateTest, SsidTruncateInvalid) {
   std::string wifi_setname2 = "SSID TEST \x01\xff!";
   std::string wifi_setname2_result = "SSID TEST \xEF\xBF\xBD\xEF\xBF\xBD!";
   EXPECT_TRUE(SetStringProperty(flimflam::kNameProperty, wifi_setname2));
+  SignalInitialPropertiesReceived();
   EXPECT_EQ(network_state_.name(), wifi_setname2_result);
 }
 
@@ -106,7 +112,8 @@ TEST_F(NetworkStateTest, SsidLatin) {
   std::string wifi_latin1_hex =
       base::HexEncode(wifi_latin1.c_str(), wifi_latin1.length());
   std::string wifi_latin1_result = "latin-1 \u00c0\u00cb\u00cc\u00d6\u00fb";
-  EXPECT_TRUE(SetStringProperty(flimflam::kWifiHexSsid, wifi_latin1_hex));
+  SetStringProperty(flimflam::kWifiHexSsid, wifi_latin1_hex);
+  SignalInitialPropertiesReceived();
   EXPECT_EQ(network_state_.name(), wifi_latin1_result);
 }
 
@@ -115,6 +122,7 @@ TEST_F(NetworkStateTest, SsidHex) {
   std::string wifi_hex = "5468697320697320484558205353494421";
   std::string wifi_hex_result = "This is HEX SSID!";
   SetStringProperty(flimflam::kWifiHexSsid, wifi_hex);
+  SignalInitialPropertiesReceived();
   EXPECT_EQ(network_state_.name(), wifi_hex_result);
 }