NetworkState cleanup, pass properties to InitialPropertiesReceived

chromeos/network/network_state_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_state.h"
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/values.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 namespace chromeos {
 
 namespace {
 
 class TestStringValue : public base::Value {

[pneubeck (no reviews), 2013/07/29 19:13:25]

Because I stumbled over this before and needs a lot of investigation to
understand, please add a comment why this is TestStringValue is required. My
guess: for utf8 error testing. But that would actually mean, that the Shill/Dbus
interface would create invalid base::Values, wouldn't it?

[stevenjb, 2013/07/29 20:25:47]

This code predates https://chromiumcodereview.appspot.com/11418048 and can now
be removed.
Done.

  public:
   explicit TestStringValue(const std::string& in_value)
       : base::Value(TYPE_STRING),
         value_(in_value) {
   }
 
   virtual ~TestStringValue() {
   }
 
   // Overridden from Value:
@@ skipping 18 matching lines @@
   std::string value_;
 };
 
 class NetworkStateTest : public testing::Test {
  public:
   NetworkStateTest() : network_state_("test_path") {
   }
 
  protected:
   bool SetStringProperty(const std::string& key, const std::string& value) {
-    if (!network_state_.PropertyChanged(key, TestStringValue(value)))
-      return false;
-    network_state_.InitialPropertiesReceived();
-    return true;
+    bool res = network_state_.PropertyChanged(key, TestStringValue(value));
+    properties_.SetStringWithoutPathExpansion(key, value);
+    return res;
+  }
+
+  void SignalInitialPropertiesReceived() {

[pneubeck (no reviews), 2013/07/29 19:13:25]

If InitialPropertiesReceived returns a bool, then it should be check in the test
too.

[stevenjb, 2013/07/29 20:25:47]

Done.

+    network_state_.InitialPropertiesReceived(properties_);
   }
 
   NetworkState network_state_;
 
  private:
+  base::DictionaryValue properties_;
+
   DISALLOW_COPY_AND_ASSIGN(NetworkStateTest);
 };
 
 }  // namespace
 
 // Seting kNameProperty should set network name after call to
 // InitialPropertiesReceived() in SetStringProperty().
 TEST_F(NetworkStateTest, SsidAscii) {
   std::string wifi_setname = "SSID TEST";
   std::string wifi_setname_result = "SSID TEST";
@@ skipping 14 matching lines @@
   std::string wifi_utf8_result = "UTF-8 \xE3\x81\x82\xE3\x81\x84\xE3\x81\x86";
   EXPECT_TRUE(SetStringProperty(flimflam::kNameProperty, wifi_utf8));
   EXPECT_EQ(network_state_.name(), wifi_utf8_result);
 }
 
 // Truncates invalid UTF-8
 TEST_F(NetworkStateTest, SsidTruncateInvalid) {
   std::string wifi_setname2 = "SSID TEST \x01\xff!";
   std::string wifi_setname2_result = "SSID TEST \xEF\xBF\xBD\xEF\xBF\xBD!";
   EXPECT_TRUE(SetStringProperty(flimflam::kNameProperty, wifi_setname2));
+  SignalInitialPropertiesReceived();
   EXPECT_EQ(network_state_.name(), wifi_setname2_result);
 }
 
 // latin1 SSID -> UTF8 SSID (Hex)
 TEST_F(NetworkStateTest, SsidLatin) {
   std::string wifi_latin1 = "latin-1 \xc0\xcb\xcc\xd6\xfb";
   std::string wifi_latin1_hex =
       base::HexEncode(wifi_latin1.c_str(), wifi_latin1.length());
   std::string wifi_latin1_result = "latin-1 \u00c0\u00cb\u00cc\u00d6\u00fb";
-  EXPECT_TRUE(SetStringProperty(flimflam::kWifiHexSsid, wifi_latin1_hex));
+  SetStringProperty(flimflam::kWifiHexSsid, wifi_latin1_hex);
+  SignalInitialPropertiesReceived();
   EXPECT_EQ(network_state_.name(), wifi_latin1_result);
 }
 
 // Hex SSID
 TEST_F(NetworkStateTest, SsidHex) {
   std::string wifi_hex = "5468697320697320484558205353494421";
   std::string wifi_hex_result = "This is HEX SSID!";
   SetStringProperty(flimflam::kWifiHexSsid, wifi_hex);
+  SignalInitialPropertiesReceived();
   EXPECT_EQ(network_state_.name(), wifi_hex_result);
 }
 
 }  // namespace chromeos