third_party/WebKit/LayoutTests/http/tests/websocket/workers/resources/cookie-ws-to-ws.js - Issue 2102993002: Fix WebSocket to set first party for cookies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/websocket/workers/resources/cookie-ws-to-ws.js

Issue 2102993002: Fix WebSocket to set first party for cookies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODO for mkwst Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/security/cookies/websocket/first-party-cookie-accepted.html ('K') | « third_party/WebKit/LayoutTests/http/tests/websocket/set-cookie_wsh.py ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/websocket/workers/resources/cookie-ws-to-ws.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/websocket/workers/resources/cookie-ws-to-ws.js b/third_party/WebKit/LayoutTests/http/tests/websocket/workers/resources/cookie-ws-to-ws.js

index a38e2c1712af01e511868114bfb82c44e6fe2900..4b2d5dcf18fa1cdbfe583ad3a5996d64dc9e8fc6 100644

--- a/third_party/WebKit/LayoutTests/http/tests/websocket/workers/resources/cookie-ws-to-ws.js

+++ b/third_party/WebKit/LayoutTests/http/tests/websocket/workers/resources/cookie-ws-to-ws.js

@@ -48,8 +48,8 @@ function runTests()

.then(echoCookie)

.then(

function (cookie) {

- if (cookie != 'WK-WebSocket-test-domain-pass=1; WK-WebSocket-test-path-pass=1; WK-WebSocket-test=1')

- return Promise.reject('Echoed cookie is incorrect');

+ if (cookie != 'WK-WebSocket-test-domain-pass=1; WK-WebSocket-test-path-pass=1; WK-WebSocket-test=1; same-site-strict=1; same-site-lax=1')

+ return Promise.reject('Echoed cookie is incorrect: ' + cookie);

postMessage("DONE");

}