third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h - Issue 2102993002: Fix WebSocket to set first party for cookies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h

Issue 2102993002: Fix WebSocket to set first party for cookies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODO for mkwst Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/security/cookies/websocket/first-party-cookie-accepted.html ('K') | « third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h

diff --git a/third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h b/third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h

index df17eba7f96730e0f2e13895e8bfff32423b5a9f..738ca0844c2985d39a5868b0a468aa20bfb76838 100644

--- a/third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h

+++ b/third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h

@@ -57,7 +57,7 @@ public:

virtual ~WebSocketHandle() { }

- virtual void connect(const WebURL&, const WebVector<WebString>& protocols, const WebSecurityOrigin&, const WebString& user_agent_override, WebSocketHandleClient*) = 0;

+ virtual void connect(const WebURL&, const WebVector<WebString>& protocols, const WebSecurityOrigin&, const WebURL&, const WebString& user_agent_override, WebSocketHandleClient*) = 0;

yhirano 2016/07/06 11:19:08 Please add the name for the second WebURL paramete

tyoshino (SeeGerritForStatus) 2016/07/07 07:00:45 Done.

virtual void send(bool fin, MessageType, const char* data, size_t /* size */) = 0;

virtual void flowControl(int64_t quota) = 0;

virtual void close(unsigned short code, const WebString& reason) = 0;