Change MessagePumpForGpu and SharedMemory to ScopedHandle

Change MessagePumpForGpu and SharedMemory to ScopedHandle.

One of the suspected reasons for GPU hangs is handle
recycling with subsequent usage of the old closed handle - either
closing it again or waiting on it.

Changing these two classes from plain HANDLE to ScopedHandle
should help to verify at least the double close case.
It should help to detect handle leaks too.

BUG=620904
Committed: https://crrev.com/2660facba19f2101c6c9c67e2739511baf4cb6b8
Cr-Commit-Position: refs/heads/master@{#403082}

[stanisc, 2016-06-29 18:34:16]

Description was changed from

==========
Change MessagePumpForGpu and SharedMemoryHandle to ScopedHandle

BUG=
==========

to

==========
Change MessagePumpForGpu and SharedMemory to ScopedHandle.

One of the suspected reasons for GPU hangs is handle
recycling with subsequent usage of the old closed handle - either
closing it again or waiting on it.

Changing these two classes from plain HANDLE to ScopedHandle
should help to verify at least the double close case.
It should help to detect handle leaks too.

BUG=
==========

[stanisc, 2016-06-29 18:36:17]

stanisc@chromium.org changed reviewers:
+ thestig@chromium.org

[stanisc, 2016-06-29 18:36:18]

PTAL

https://codereview.chromium.org/2102923002/diff/20001/base/memory/shared_memo...
File base/memory/shared_memory_unittest.cc (left):

https://codereview.chromium.org/2102923002/diff/20001/base/memory/shared_memo...
base/memory/shared_memory_unittest.cc:595: SharedMemory
shared_memory_handle_dup(
This part of the test is redundant (identical to the next one). And it was
causing a problem due to double tracking / double closing of the handle.

https://codereview.chromium.org/2102923002/diff/20001/base/metrics/persistent...
File base/metrics/persistent_memory_allocator_unittest.cc (right):

https://codereview.chromium.org/2102923002/diff/20001/base/metrics/persistent...
base/metrics/persistent_memory_allocator_unittest.cc:556:
std::unique_ptr<SharedMemory> shmem3(new SharedMemory(shared_handle_2,
Changed this to avoid double tracking of the same handle.

[Lei Zhang, 2016-06-29 18:42:53]

Is there a relevant BUG= entry?

[Lei Zhang, 2016-06-29 18:47:15]

lgtm

https://codereview.chromium.org/2102923002/diff/20001/base/memory/shared_memo...
File base/memory/shared_memory.h (right):

https://codereview.chromium.org/2102923002/diff/20001/base/memory/shared_memo...
base/memory/shared_memory.h:270: win::ScopedHandle mapped_file_;
nit: extra space to keep the variable names lined up, since it's mostly that
way?

[stanisc, 2016-06-29 21:13:32]

Description was changed from

==========
Change MessagePumpForGpu and SharedMemory to ScopedHandle.

One of the suspected reasons for GPU hangs is handle
recycling with subsequent usage of the old closed handle - either
closing it again or waiting on it.

Changing these two classes from plain HANDLE to ScopedHandle
should help to verify at least the double close case.
It should help to detect handle leaks too.

BUG=
==========

to

==========
Change MessagePumpForGpu and SharedMemory to ScopedHandle.

One of the suspected reasons for GPU hangs is handle
recycling with subsequent usage of the old closed handle - either
closing it again or waiting on it.

Changing these two classes from plain HANDLE to ScopedHandle
should help to verify at least the double close case.
It should help to detect handle leaks too.

BUG=620904
==========

[stanisc, 2016-06-29 21:29:06]

https://codereview.chromium.org/2102923002/diff/20001/base/memory/shared_memo...
File base/memory/shared_memory.h (right):

https://codereview.chromium.org/2102923002/diff/20001/base/memory/shared_memo...
base/memory/shared_memory.h:270: win::ScopedHandle mapped_file_;
On 2016/06/29 18:47:15, Lei Zhang wrote:
> nit: extra space to keep the variable names lined up, since it's mostly that
> way?

Done.

[stanisc, 2016-06-30 00:09:52]

The CQ bit was checked by stanisc@chromium.org

[stanisc, 2016-06-30 00:09:53]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2102923002/#ps40001
(title: "Fixed spacing and added Bug ID")

[commit-bot: I haz the power, 2016-06-30 00:10:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 02:26:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 02:26:13]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Lei Zhang, 2016-06-30 02:56:07]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-06-30 02:56:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 03:48:03]

Description was changed from

==========
Change MessagePumpForGpu and SharedMemory to ScopedHandle.

One of the suspected reasons for GPU hangs is handle
recycling with subsequent usage of the old closed handle - either
closing it again or waiting on it.

Changing these two classes from plain HANDLE to ScopedHandle
should help to verify at least the double close case.
It should help to detect handle leaks too.

BUG=620904
==========

to

==========
Change MessagePumpForGpu and SharedMemory to ScopedHandle.

One of the suspected reasons for GPU hangs is handle
recycling with subsequent usage of the old closed handle - either
closing it again or waiting on it.

Changing these two classes from plain HANDLE to ScopedHandle
should help to verify at least the double close case.
It should help to detect handle leaks too.

BUG=620904
==========

[commit-bot: I haz the power, 2016-06-30 03:48:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-30 03:48:14]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 03:51:38]

Description was changed from

==========
Change MessagePumpForGpu and SharedMemory to ScopedHandle.

One of the suspected reasons for GPU hangs is handle
recycling with subsequent usage of the old closed handle - either
closing it again or waiting on it.

Changing these two classes from plain HANDLE to ScopedHandle
should help to verify at least the double close case.
It should help to detect handle leaks too.

BUG=620904
==========

to

==========
Change MessagePumpForGpu and SharedMemory to ScopedHandle.

One of the suspected reasons for GPU hangs is handle
recycling with subsequent usage of the old closed handle - either
closing it again or waiting on it.

Changing these two classes from plain HANDLE to ScopedHandle
should help to verify at least the double close case.
It should help to detect handle leaks too.

BUG=620904

Committed: https://crrev.com/2660facba19f2101c6c9c67e2739511baf4cb6b8
Cr-Commit-Position: refs/heads/master@{#403082}
==========

[commit-bot: I haz the power, 2016-06-30 03:51:39]

Patchset 3 (id:??) landed as
https://crrev.com/2660facba19f2101c6c9c67e2739511baf4cb6b8
Cr-Commit-Position: refs/heads/master@{#403082}