Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3361)

Unified Diff: base/message_loop/message_pump_win.cc

Issue 2102923002: Change MessagePumpForGpu and SharedMemory to ScopedHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed spacing and added Bug ID Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop/message_pump_win.h ('k') | base/metrics/persistent_memory_allocator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_pump_win.cc
diff --git a/base/message_loop/message_pump_win.cc b/base/message_loop/message_pump_win.cc
index d3a762ad59834d31256e15fa804c3049d96ed4c0..de20bdc084dc7e2c0df81108a70a9d1bc9410b70 100644
--- a/base/message_loop/message_pump_win.cc
+++ b/base/message_loop/message_pump_win.cc
@@ -510,14 +510,12 @@ bool MessagePumpForUI::ProcessPumpReplacementMessage() {
//-----------------------------------------------------------------------------
// MessagePumpForGpu public:
-MessagePumpForGpu::MessagePumpForGpu()
- : event_(CreateEvent(nullptr, FALSE, FALSE, nullptr)) {
+MessagePumpForGpu::MessagePumpForGpu() {
+ event_.Set(CreateEvent(nullptr, FALSE, FALSE, nullptr));
InitUser32APIs();
}
-MessagePumpForGpu::~MessagePumpForGpu() {
- CloseHandle(event_);
-}
+MessagePumpForGpu::~MessagePumpForGpu() {}
// static
void MessagePumpForGpu::InitFactory() {
@@ -540,7 +538,7 @@ void MessagePumpForGpu::ScheduleWork() {
last_set_event_timeticks_ = TimeTicks::Now();
// Make sure the MessagePump does some work for us.
- SetEvent(event_);
+ SetEvent(event_.Get());
}
void MessagePumpForGpu::ScheduleDelayedWork(
@@ -553,7 +551,7 @@ void MessagePumpForGpu::ScheduleDelayedWork(
bool MessagePumpForGpu::WasSignaled() {
// If |event_| was set this would reset it back to unset state.
- return WaitForSingleObject(event_, 0) == WAIT_OBJECT_0;
+ return WaitForSingleObject(event_.Get(), 0) == WAIT_OBJECT_0;
}
//-----------------------------------------------------------------------------
@@ -621,8 +619,9 @@ void MessagePumpForGpu::WaitForWork() {
debug::Alias(&wait_for_work_timeticks);
debug::Alias(&delay);
+ HANDLE handle = event_.Get();
DWORD result =
- g_msg_wait_for_multiple_objects_ex(1, &event_, delay, QS_ALLINPUT, 0);
+ g_msg_wait_for_multiple_objects_ex(1, &handle, delay, QS_ALLINPUT, 0);
DCHECK_NE(WAIT_FAILED, result) << GetLastError();
if (result != WAIT_TIMEOUT) {
// Either work or message available.
« no previous file with comments | « base/message_loop/message_pump_win.h ('k') | base/metrics/persistent_memory_allocator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698