Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2102883003: [Merge to 2774] Don't check IOSurfaceIsInUse for IOSurfaces wrapped in a CVPixelBuffer. (Closed)

Created:
4 years, 5 months ago by erikchen
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2774
Target Ref:
refs/pending/branch-heads/2774
Project:
chromium
Visibility:
Public.

Description

[Merge to 2774] Don't check IOSurfaceIsInUse for IOSurfaces wrapped in a CVPixelBuffer. It always returns true, even when the Window Server is no longer using it. CVPixelBufferPool does the appropriate checking. BUG=621899 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2085173002 Cr-Commit-Position: refs/heads/master@{#401217} (cherry picked from commit 0f5be6cf7b919397dd97ee350b1a663227ac13ea) Committed: https://chromium.googlesource.com/chromium/src/+/9c0c4f89a3fceb36a8b9d9b4d4d39618f4fb09fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -37 lines) Patch
M gpu/ipc/service/image_transport_surface_overlay_mac.h View 1 chunk +1 line, -14 lines 0 comments Download
M gpu/ipc/service/image_transport_surface_overlay_mac.mm View 3 chunks +11 lines, -23 lines 0 comments Download
M ui/gl/gl_image_io_surface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_image_io_surface.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
erikchen
4 years, 5 months ago (2016-06-28 20:32:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c0c4f89a3fceb36a8b9d9b4d4d39618f4fb09fb.

Powered by Google App Engine
This is Rietveld 408576698