Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2085173002: Don't check IOSurfaceIsInUse for IOSurfaces wrapped in a CVPixelBuffer. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
Reviewers:
ccameron
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't check IOSurfaceIsInUse for IOSurfaces wrapped in a CVPixelBuffer. It always returns true, even when the Window Server is no longer using it. CVPixelBufferPool does the appropriate checking. BUG=621899 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/0f5be6cf7b919397dd97ee350b1a663227ac13ea Cr-Commit-Position: refs/heads/master@{#401217}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -37 lines) Patch
M gpu/ipc/service/image_transport_surface_overlay_mac.h View 1 chunk +1 line, -14 lines 1 comment Download
M gpu/ipc/service/image_transport_surface_overlay_mac.mm View 3 chunks +11 lines, -23 lines 0 comments Download
M ui/gl/gl_image_io_surface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_image_io_surface.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
erikchen
ccameron: Please review.
4 years, 6 months ago (2016-06-22 01:40:54 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085173002/1
4 years, 6 months ago (2016-06-22 01:41:55 UTC) #5
ccameron
lgtm https://codereview.chromium.org/2085173002/diff/1/gpu/ipc/service/image_transport_surface_overlay_mac.h File gpu/ipc/service/image_transport_surface_overlay_mac.h (left): https://codereview.chromium.org/2085173002/diff/1/gpu/ipc/service/image_transport_surface_overlay_mac.h#oldcode103 gpu/ipc/service/image_transport_surface_overlay_mac.h:103: struct IOSurfaceInUseQuery { Seems like reasonable cleanp.
4 years, 6 months ago (2016-06-22 02:06:22 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 02:52:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085173002/1
4 years, 6 months ago (2016-06-22 06:41:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 06:45:31 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 06:47:07 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f5be6cf7b919397dd97ee350b1a663227ac13ea
Cr-Commit-Position: refs/heads/master@{#401217}

Powered by Google App Engine
This is Rietveld 408576698