Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Issue 2102853002: [Mac][Material Design] Adjust (i) and lock Omnibox icons. (Closed)

Created:
4 years, 5 months ago by shrike
Modified:
4 years, 5 months ago
Reviewers:
tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Adjust (i) and lock Omnibox icons. This cl brings the (i) icon into spec, and adjusts the position of the lock icon. The same lock icon is used in https-valid and ev modes but appears 1px too low in evcert mode on Retina machines. The issue is the text label that appears next to the lock is 1px too high - this cl fixes the position of the text label as well. R=tapted@chromium.org BUG=621277 Review-Url: https://codereview.chromium.org/2077743005 Cr-Commit-Position: refs/heads/master@{#401666} (cherry picked from commit 56a023d3893944b000d4e3fa17fe9b6c5d492c48) Committed: https://chromium.googlesource.com/chromium/src/+/8fcb23b09379b9f26a2f4fb82829123c681ed5cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -15 lines) Patch
M chrome/browser/ui/cocoa/location_bar/bubble_decoration.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm View 4 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 3 chunks +27 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
shrike
4 years, 5 months ago (2016-06-27 23:28:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8fcb23b09379b9f26a2f4fb82829123c681ed5cf.

Powered by Google App Engine
This is Rietveld 408576698