chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm - Issue 2102853002: [Mac][Material Design] Adjust (i) and lock Omnibox icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm

Issue 2102853002: [Mac][Material Design] Adjust (i) and lock Omnibox icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm ('k') | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm b/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm

index 58028b62e4b7a2ebdb8a317dd24a0e813a3f8454..b48bb4ac7623f7732ad77a45a97c108267db2f7c 100644

--- a/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm

+++ b/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm

@@ -57,7 +57,12 @@ NSColor* ColorWithRGBBytes(int rr, int gg, int bb) {

EVBubbleDecoration::EVBubbleDecoration(LocationIconDecoration* location_icon)

: location_icon_(location_icon) {

- if (!ui::MaterialDesignController::IsModeMaterial()) {

+ if (ui::MaterialDesignController::IsModeMaterial()) {

+ // On Retina the text label is 1px above the Omnibox textfield's text

+ // baseline. If the Omnibox textfield also drew the label the baselines

+ // would align.

+ SetRetinaBaselineOffset(0.5);

+ } else {

// Color tuples stolen from location_bar_view_gtk.cc.

SetTextColor(ColorWithRGBBytes(0x07, 0x95, 0x00));

}