Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2102663002: Fix Mac accessibility window attribute inside child frames. (Closed)

Created:
4 years, 5 months ago by dmazzoni
Modified:
4 years, 5 months ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Mac accessibility window attribute inside child frames. BUG=none Committed: https://crrev.com/105b415141fc9f2bf784a4c4bf1c85ad48c2b05b Cr-Commit-Position: refs/heads/master@{#402357}

Patch Set 1 #

Patch Set 2 : ToBrowserAccessibilityManagerMac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 chunks +7 lines, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dmazzoni
4 years, 5 months ago (2016-06-27 17:37:41 UTC) #2
nektarios
Could we add a ToBrowserAccessibilityManagerMac method, like we have for the other platforms, instead of ...
4 years, 5 months ago (2016-06-27 18:37:15 UTC) #3
nektarios
lgtm
4 years, 5 months ago (2016-06-27 18:37:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102663002/20001
4 years, 5 months ago (2016-06-27 23:38:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 01:07:27 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 01:10:03 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/105b415141fc9f2bf784a4c4bf1c85ad48c2b05b
Cr-Commit-Position: refs/heads/master@{#402357}

Powered by Google App Engine
This is Rietveld 408576698