Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Issue 2102633003: Fix Vulkan readPixels (Closed)

Created:
4 years, 5 months ago by egdaniel
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@unitTests2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix Vulkan readPixels Fixed bug with setting up tempReadTexture from previous CL. Also, previously we were not correctly handling the rowBytes during the read. BUG=skia:5461 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2102633003 Committed: https://skia.googlesource.com/skia/+/88e8aef3916454e5f6916cc8b3420345b1cf0584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -27 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 4 chunks +37 lines, -22 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
egdaniel
4 years, 5 months ago (2016-06-27 19:36:06 UTC) #3
egdaniel
4 years, 5 months ago (2016-06-27 21:12:33 UTC) #5
Brian Osman
lgtm
4 years, 5 months ago (2016-06-27 21:15:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102633003/1
4 years, 5 months ago (2016-06-27 21:16:56 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:35:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/88e8aef3916454e5f6916cc8b3420345b1cf0584

Powered by Google App Engine
This is Rietveld 408576698