third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h - Issue 2102453003: [DevTools] Move collectionEntries to internalProperties in protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

Issue 2102453003: [DevTools] Move collectionEntries to internalProperties in protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

index b9fc3dbdcf05f4c358c3cbc6c596a1684782d267..66315486f285c3e9fe0bad93e4b931069b738d76 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

@@ -101,8 +101,8 @@ public:

void setAsyncCallStackDepth(V8DebuggerAgentImpl*, int);

v8::MaybeLocal<v8::Value> functionScopes(v8::Local<v8::Function>);

+ v8::MaybeLocal<v8::Array> internalProperties(v8::Local<v8::Context>, v8::Local<v8::Value>);

v8::Local<v8::Value> generatorObjectDetails(v8::Local<v8::Object>&);

- v8::Local<v8::Value> collectionEntries(v8::Local<v8::Object>&);

v8::Isolate* isolate() const { return m_isolate; }

V8DebuggerClient* client() { return m_client; }

@@ -162,6 +162,8 @@ private:

using ContextsByGroupMap = protocol::HashMap<int, std::unique_ptr<ContextByIdMap>>;

+ v8::Local<v8::Value> collectionEntries(v8::Local<v8::Context>, v8::Local<v8::Object>);

v8::Isolate* m_isolate;

V8DebuggerClient* m_client;

ContextsByGroupMap m_contexts;